-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add health checks for breaking changes, changelogs, pubspecs, etc #8314
base: master
Are you sure you want to change the base?
Conversation
cc @bkonyi I also see this failure https://github.com/flutter/devtools/actions/runs/10780298465 it looks like there is a transitive dep on a new GitHub action, and those have to be allow listed somehow. Any ideas? |
Sorry for the delayed response. I'll be honest, I know nothing about GitHub actions 😬 |
@kenzieschmoll do you have any ideas how this check is set up? Maybe something in the admin settings for the repo? |
It looks like it probably is in the settings for the repo, see https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository. We will need an admin to approve of this new action and add it to the list. Does anybody know who an admin is for this repo? cc @devoncarew @kevmoo ? |
For repos in the |
@kenzieschmoll is an admin for this repo, I am not familiar with how the github actions are set up here. |
I don't have the ability to add a new action, the text field is disabled for me: |
Same, I also cannot edit the text field. 🤔 |
(triage): @Piinks Did the infra people have any advice? |
Alas, they did not. 😞 Will take a look again in the new year, there may be an obscure setting that is causing this to be disabled. |
Add a health check job that checks various things, such as changelog entries and proper semver.
Would avoid issues such as the one in #8291 where breaking changes are accidentally released in non-breaking versions.
I am not actually sure this works with repos that are a mixture of flutter and dart packages, we might need some extra functionality from the health check tool if this fails on the non-flutter packages.
Pre-launch Checklist
///
).