[video_player_avplay] Fix not display video issue when start play (#644)

flutter-tizen · Dec 27, 2023 · 0d363f0 · 0d363f0
1 parent b87dadb
commit 0d363f0
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 14 deletions.
diff --git a/packages/video_player_avplay/CHANGELOG.md b/packages/video_player_avplay/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.1.3
+
+* Fix issue of not display video when start play.
+
 ## 0.1.2
 
 * Replace surface id with resource id for fixing overlap issue.

diff --git a/packages/video_player_avplay/README.md b/packages/video_player_avplay/README.md
@@ -12,7 +12,7 @@ To use this package, add `video_player_avplay` as a dependency in your `pubspec.
 
 ```yaml
 dependencies:
-  video_player_avplay: ^0.1.2
+  video_player_avplay: ^0.1.3
 ```
 
 Then you can import `video_player_avplay` in your Dart code:

diff --git a/packages/video_player_avplay/lib/video_player.dart b/packages/video_player_avplay/lib/video_player.dart
@@ -574,11 +574,6 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> {
           _updatePosition(newPosition);
         },
       );
-
-      // This ensures that the correct playback speed is always applied when
-      // playing back. This is necessary because we do not set playback speed
-      // when paused.
-      await _applyPlaybackSpeed();
     } else {
       _timer?.cancel();
       await _videoPlayerPlatform.pause(_playerId);
@@ -597,13 +592,6 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> {
       return;
     }
 
-    // Setting the playback speed on iOS will trigger the video to play. We
-    // prevent this from happening by not applying the playback speed until
-    // the video is manually played from Flutter.
-    if (!value.isPlaying) {
-      return;
-    }
-
     await _videoPlayerPlatform.setPlaybackSpeed(
       _playerId,
       value.playbackSpeed,

diff --git a/packages/video_player_avplay/pubspec.yaml b/packages/video_player_avplay/pubspec.yaml
@@ -2,7 +2,7 @@ name: video_player_avplay
 description: Flutter plugin for displaying inline video on Tizen TV devices.
 homepage: https://github.com/flutter-tizen/plugins
 repository: https://github.com/flutter-tizen/plugins/tree/master/packages/video_player_avplay
-version: 0.1.2
+version: 0.1.3
 
 environment:
   sdk: ">=2.18.0 <4.0.0"

diff --git a/packages/video_player_avplay/tizen/src/plus_player.cc b/packages/video_player_avplay/tizen/src/plus_player.cc
@@ -618,6 +618,10 @@ void PlusPlayer::OnPrepareDone(bool ret, void *user_data) {
   LOG_INFO("[PlusPlayer] Prepare done, result: %d.", ret);
   PlusPlayer *self = reinterpret_cast<PlusPlayer *>(user_data);
 
+  if (!SetDisplayVisible(self->player_, true)) {
+    LOG_ERROR("[PlusPlayer] Fail to set display visible.");
+  }
+
   if (!self->is_initialized_ && ret) {
     self->SendInitialized();
   }