-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for platformPayCreatePaymentMethod error #1882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks looks good to me!
can you resolve the conflicts? |
Resolved merge conflicts 👍 |
I also found an issue: when I cancel Apple Pay, this listener method is ineffective: paymentRequest.onCancel(() {}). It is necessary to change void onCancel(void Function() callback) { import 'dart:js_util'; You might as well fix this issue at the same time. @EduardDumitrescu |
@EduardDumitrescu Looks like some tests failed. Any updates on this? |
… into mobile_pay_web # Conflicts: # packages/stripe_js/CHANGELOG.md # packages/stripe_js/pubspec.yaml # packages/stripe_web/pubspec.yaml
… into mobile_pay_web # Conflicts: # packages/stripe_js/lib/src/js/payment_requests/payment_request.dart # packages/stripe_web/pubspec.yaml
Hello, I don't quite understand what I'm supposed to do with the tests. Locally they work(because I have my key set in env) and the error on the pipeline is 'IntegrationError: Please call Stripe() with your publishable key. You used an empty string.' . Maybe the pipeline is supposed to set the a stripe key and for some reason it doesn't on this pr? @remonh87 Do you have any idea what must be done? |
I decided to merge it because everything looks fine |
Refactor for -> #1879