-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/deferred payment methods #1839
Fix/deferred payment methods #1839
Conversation
thank you for your contribution however we do not change the underlying stripe sdk. If you want this behavior to change you should create an pr for https://github.com/stripe/stripe-react-native . |
We will however merge the Android part |
Sorry, I didn't realize that you are mirroring the external SDK. I will push an alternative solution from flutter_stripe side. |
Hi @remonh87 , @jonasbark do you think that the new commit can solve the issue? |
setupFutureUsage: modeParams["setupFutureUsage"] != nil | ||
? (modeParams["setupFutureUsage"] as? String == "OffSession" ? .offSession : .onSession) | ||
: nil, | ||
setupFutureUsage: { return switch modeParams["setupFutureUsage"] as? String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this change and let's go for a fix in dart or we need to make a change to stripe ios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought to have removed it in last commit, while fixing it in dart, let me check when I return home
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, check it now again, please
…to fix/deferred_payment_methods
Fixes #1837