Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/deferred payment methods #1839

Merged
merged 7 commits into from
Jul 17, 2024

Conversation

pgiacomo69
Copy link
Contributor

Fixes #1837

@remonh87
Copy link
Member

thank you for your contribution however we do not change the underlying stripe sdk. If you want this behavior to change you should create an pr for https://github.com/stripe/stripe-react-native .

@remonh87 remonh87 self-requested a review July 10, 2024 07:26
@jonasbark
Copy link
Member

We will however merge the Android part

@pgiacomo69
Copy link
Contributor Author

Sorry, I didn't realize that you are mirroring the external SDK. I will push an alternative solution from flutter_stripe side.

@pgiacomo69
Copy link
Contributor Author

Hi @remonh87 , @jonasbark do you think that the new commit can solve the issue?
Thank you 👍

setupFutureUsage: modeParams["setupFutureUsage"] != nil
? (modeParams["setupFutureUsage"] as? String == "OffSession" ? .offSession : .onSession)
: nil,
setupFutureUsage: { return switch modeParams["setupFutureUsage"] as? String {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this change and let's go for a fix in dart or we need to make a change to stripe ios

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought to have removed it in last commit, while fixing it in dart, let me check when I return home

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, check it now again, please

@remonh87 remonh87 merged commit c6f4100 into flutter-stripe:main Jul 17, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payment Methods inconsistencies when using PaymentSheet in deferred mode
4 participants