-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for checking platform pay availability on web #1478
Add support for checking platform pay availability on web #1478
Conversation
cornwe19
commented
Nov 9, 2023
- Intended as first in a series of PRs to support platform pay on web
- Partially addresses Google pay and Apple pay with Web #1122
@remonh87 @jonasbark @jamesblasco Looking for some feedback in particular on the interface change I had to make to Let me know if there's some alternative method to supply the information Stripe JS needs that better fits with the structure of this SDK. |
@remonh87 @jonasbark @jamesblasco Hey guys, any initial feedback on the direction I'm headed with this one? Thanks! |
60d969b
to
7d8a4ae
Compare
Planning to continue forward with a PR to start supporting actually rendering a Payment Request Button @remonh87 @jonasbark @jamesblasco Curious if any of you have feedback on the direction I'm headed here before I start building off this code. Thanks, guys |
Sorry for the lack of reply - we do not have a concept of how to move forward with Web support. Generally, I think your contribution looks good, thank you! |
7d8a4ae
to
6f4bff7
Compare
@jonasbark thanks for the approval. I fixed up some formatting that was triggering a build failure and rebased to get up to speed with main. Hoping next time checks run, this PR should be in good shape. |
* Partially addresses flutter-stripe#1122
6f4bff7
to
35c6fe2
Compare
@jonasbark I'm noticing a couple of the status checks on this PR are failing for reasons that appear unrelated to code I've changed here. I'm seeing errors like the following from stripe_js and what appears to be a connectivity issue from the iOS integration tests
Are there any steps I need to take to resolve these? |
@remonh87 @jonasbark @jamesblasco hey guys, is there anything blocking this PR from being merged? I have a follow up PR ready that fully implements the platform pay button UI and createPlatformPayPaymentMethod for web and I'm unsure if I should wait for this to be merged or just close this and open a larger PR with both the isPlatformPaySupported and createPlatformPayPaymentMethod methods implemented on web |
Superseded by #1565 |