Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for checking platform pay availability on web #1478

Closed

Conversation

cornwe19
Copy link
Contributor

@cornwe19 cornwe19 commented Nov 9, 2023

@cornwe19
Copy link
Contributor Author

cornwe19 commented Nov 9, 2023

@remonh87 @jonasbark @jamesblasco Looking for some feedback in particular on the interface change I had to make to StripePlatform.isPlatformPaySupported to support checking for PaymentRequest availability on web.

Let me know if there's some alternative method to supply the information Stripe JS needs that better fits with the structure of this SDK.

@cornwe19
Copy link
Contributor Author

@remonh87 @jonasbark @jamesblasco Hey guys, any initial feedback on the direction I'm headed with this one? Thanks!

@cornwe19 cornwe19 force-pushed the feature/1122-wallet-pay-web branch from 60d969b to 7d8a4ae Compare November 30, 2023 19:59
@cornwe19
Copy link
Contributor Author

cornwe19 commented Dec 1, 2023

Planning to continue forward with a PR to start supporting actually rendering a Payment Request Button

@remonh87 @jonasbark @jamesblasco Curious if any of you have feedback on the direction I'm headed here before I start building off this code. Thanks, guys

@jonasbark
Copy link
Member

Sorry for the lack of reply - we do not have a concept of how to move forward with Web support. Generally, I think your contribution looks good, thank you!

@cornwe19 cornwe19 force-pushed the feature/1122-wallet-pay-web branch from 7d8a4ae to 6f4bff7 Compare December 7, 2023 23:14
@cornwe19
Copy link
Contributor Author

cornwe19 commented Dec 8, 2023

@jonasbark thanks for the approval. I fixed up some formatting that was triggering a build failure and rebased to get up to speed with main. Hoping next time checks run, this PR should be in good shape.

@cornwe19 cornwe19 force-pushed the feature/1122-wallet-pay-web branch from 6f4bff7 to 35c6fe2 Compare December 13, 2023 15:24
@cornwe19
Copy link
Contributor Author

@jonasbark I'm noticing a couple of the status checks on this PR are failing for reasons that appear unrelated to code I've changed here.

I'm seeing errors like the following from stripe_js
IntegrationError: Please call Stripe() with your publishable key. You used an empty string.

and what appears to be a connectivity issue from the iOS integration tests

flutter: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
flutter: The following ClientException was thrown running a test:
flutter: Connection closed before full header was received, uri=http://192.168.64.23:4242/payment-sheet

Are there any steps I need to take to resolve these?

@cornwe19
Copy link
Contributor Author

@remonh87 @jonasbark @jamesblasco hey guys, is there anything blocking this PR from being merged? I have a follow up PR ready that fully implements the platform pay button UI and createPlatformPayPaymentMethod for web and I'm unsure if I should wait for this to be merged or just close this and open a larger PR with both the isPlatformPaySupported and createPlatformPayPaymentMethod methods implemented on web

@cornwe19
Copy link
Contributor Author

Superseded by #1565

@cornwe19 cornwe19 closed this Jan 24, 2024
@cornwe19 cornwe19 deleted the feature/1122-wallet-pay-web branch February 14, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants