chore: fix analyzer issues example app

flutter-stripe · Dec 15, 2024 · 62faac2 · 62faac2
1 parent 2c8f90c
commit 62faac2
Show file tree

Hide file tree

Showing 31 changed files with 443 additions and 289 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -19,6 +19,7 @@ analyzer:
     # TODO (albertus-stripe): Remove this once the melos PR is merged since this won't be an issue anymore
     invalid_dependency: ignore
     invalid_annotation_target: ignore #https://github.com/rrousselGit/freezed#disabling-invalid_annotation_target-warning-and-warning-in-generates-files
+    library_private_types_in_public_api: ignore
   exclude:
     - "bin/cache/**"
     - "**/*.freezed.dart"

diff --git a/example/integration_test/app_test.dart b/example/integration_test/app_test.dart
@@ -1,4 +1,5 @@
 import 'dart:convert';
+import 'dart:developer';
 
 import 'package:flutter/material.dart';
 import 'package:flutter_stripe/flutter_stripe.dart';
@@ -19,9 +20,9 @@ void main() {
   group('Payment sheet', () {
     testWidgets('init payment sheet', (_) async {
       // 1. create payment intent on the server
-      final _paymentSheetData = await _createTestPaymentSheet();
+      final paymentSheetData = await _createTestPaymentSheet();
 
-      expect(_paymentSheetData['paymentIntent'], isNotNull);
+      expect(paymentSheetData['paymentIntent'], isNotNull);
       // 2. initialize the payment sheet
       expect(
         Stripe.instance.initPaymentSheet(
@@ -33,9 +34,9 @@ void main() {
             ),
             style: ThemeMode.dark,
             merchantDisplayName: 'Flutter Stripe Store Demo',
-            customerId: _paymentSheetData['customer'],
-            paymentIntentClientSecret: _paymentSheetData['paymentIntent'],
-            customerEphemeralKeySecret: _paymentSheetData['ephemeralKey'],
+            customerId: paymentSheetData['customer'],
+            paymentIntentClientSecret: paymentSheetData['paymentIntent'],
+            customerEphemeralKeySecret: paymentSheetData['ephemeralKey'],
           ),
         ),
         completes,
@@ -90,7 +91,7 @@ void main() {
 Future<Map<String, dynamic>> _createTestPaymentSheet() async {
   // ifconfig | grep 'inet ' | grep -v '127.0.0.1' | awk '{print $2}' could return multiple IPs, divided by new line - use the last one
   final ipAddress = kApiUrl.split('\n').last.trim();
-  print('IP Address of the server: $ipAddress');
+  log('IP Address of the server: $ipAddress');
   final url = Uri.parse('http://$ipAddress:4242/payment-sheet');
   final response = await http.post(
     url,

diff --git a/example/integration_test/payment_method_test.dart b/example/integration_test/payment_method_test.dart
@@ -43,7 +43,7 @@ void main() {
         expirationMonth: 04,
         expirationYear: 2025,
       ));
-      ;
+
       final paymentIntent = await Stripe.instance.confirmPayment(
         paymentIntentClientSecret: clientSecret['clientSecret'],
         data: PaymentMethodParams.card(

diff --git a/example/lib/main.dart b/example/lib/main.dart
@@ -1,3 +1,5 @@
+// ignore_for_file: use_key_in_widget_constructors
+
 import 'package:flutter/material.dart';
 import 'package:flutter_stripe/flutter_stripe.dart';
 import 'package:stripe_example/.env.dart';
@@ -14,7 +16,7 @@ void main() async {
 }
 
 class App extends StatelessWidget {
-  const App({Key? key}) : super(key: key);
+  const App({super.key});
 
   @override
   Widget build(BuildContext context) {

diff --git a/example/lib/screens/card_payments/custom_card_payment_screen.dart b/example/lib/screens/card_payments/custom_card_payment_screen.dart
@@ -7,6 +7,8 @@ import 'package:stripe_example/config.dart';
 import 'package:stripe_example/widgets/loading_button.dart';
 
 class CustomCardPaymentScreen extends StatefulWidget {
+  const CustomCardPaymentScreen({super.key});
+
   @override
   _CustomCardPaymentScreenState createState() =>
       _CustomCardPaymentScreenState();
@@ -120,6 +122,8 @@ class _CustomCardPaymentScreenState extends State<CustomCardPaymentScreen> {
   }
 
   Future<void> _handlePayPress() async {
+    final scaffoldMessenger = ScaffoldMessenger.of(context);
+
     await Stripe.instance.dangerouslyUpdateCardDetails(_card);
 
     try {
@@ -158,16 +162,18 @@ class _CustomCardPaymentScreenState extends State<CustomCardPaymentScreen> {
 
       if (paymentIntentResult['error'] != null) {
         // Error during creating or confirming Intent
-        ScaffoldMessenger.of(context).showSnackBar(
-            SnackBar(content: Text('Error: ${paymentIntentResult['error']}')));
-        return;
+        if (context.mounted) {
+          scaffoldMessenger.showSnackBar(SnackBar(
+              content: Text('Error: ${paymentIntentResult['error']}')));
+          return;
+        }
       }
 
       if (paymentIntentResult['clientSecret'] != null &&
           paymentIntentResult['requiresAction'] == null) {
         // Payment succedeed
 
-        ScaffoldMessenger.of(context).showSnackBar(SnackBar(
+        scaffoldMessenger.showSnackBar(SnackBar(
             content:
                 Text('Success!: The payment was confirmed successfully!')));
         return;
@@ -184,25 +190,27 @@ class _CustomCardPaymentScreenState extends State<CustomCardPaymentScreen> {
           await confirmIntent(paymentIntent.id);
         } else {
           // Payment succedeed
-          ScaffoldMessenger.of(context).showSnackBar(SnackBar(
-              content: Text('Error: ${paymentIntentResult['error']}')));
+          if (context.mounted) {
+            scaffoldMessenger.showSnackBar(SnackBar(
+                content: Text('Error: ${paymentIntentResult['error']}')));
+          }
         }
       }
     } catch (e) {
-      ScaffoldMessenger.of(context)
-          .showSnackBar(SnackBar(content: Text('Error: $e')));
+      scaffoldMessenger.showSnackBar(SnackBar(content: Text('Error: $e')));
       rethrow;
     }
   }
 
   Future<void> confirmIntent(String paymentIntentId) async {
+    final scaffoldMessenger = ScaffoldMessenger.of(context);
     final result = await callNoWebhookPayEndpointIntentId(
         paymentIntentId: paymentIntentId);
-    if (result['error'] != null) {
-      ScaffoldMessenger.of(context)
+    if (result['error'] != null && context.mounted) {
+      scaffoldMessenger
           .showSnackBar(SnackBar(content: Text('Error: ${result['error']}')));
     } else {
-      ScaffoldMessenger.of(context).showSnackBar(SnackBar(
+      scaffoldMessenger.showSnackBar(SnackBar(
           content: Text('Success!: The payment was confirmed successfully!')));
     }
   }

diff --git a/example/lib/screens/card_payments/no_webhook_payment_cardform_screen.dart b/example/lib/screens/card_payments/no_webhook_payment_cardform_screen.dart
@@ -10,6 +10,8 @@ import 'package:stripe_example/widgets/loading_button.dart';
 import 'package:stripe_example/widgets/response_card.dart';
 
 class NoWebhookPaymentCardFormScreen extends StatefulWidget {
+  const NoWebhookPaymentCardFormScreen({super.key});
+
   @override
   _NoWebhookPaymentCardFormScreenState createState() =>
       _NoWebhookPaymentCardFormScreenState();
@@ -86,6 +88,8 @@ class _NoWebhookPaymentCardFormScreenState
       return;
     }
 
+    final scaffoldMessenger = ScaffoldMessenger.of(context);
+
     try {
       // 1. Gather customer billing information (ex. email)
 
@@ -120,19 +124,23 @@ class _NoWebhookPaymentCardFormScreenState
 
       if (paymentIntentResult['error'] != null) {
         // Error during creating or confirming Intent
-        ScaffoldMessenger.of(context).showSnackBar(
-            SnackBar(content: Text('Error: ${paymentIntentResult['error']}')));
+        if (context.mounted) {
+          scaffoldMessenger.showSnackBar(SnackBar(
+              content: Text('Error: ${paymentIntentResult['error']}')));
+        }
         return;
       }
 
       if (paymentIntentResult['clientSecret'] != null &&
           paymentIntentResult['requiresAction'] == null) {
         // Payment succedeed
 
-        ScaffoldMessenger.of(context).showSnackBar(SnackBar(
-            content:
-                Text('Success!: The payment was confirmed successfully!')));
-        return;
+        if (context.mounted) {
+          scaffoldMessenger.showSnackBar(SnackBar(
+              content:
+                  Text('Success!: The payment was confirmed successfully!')));
+          return;
+        }
       }
 
       if (paymentIntentResult['clientSecret'] != null &&
@@ -153,27 +161,34 @@ class _NoWebhookPaymentCardFormScreenState
           // 5. Call API to confirm intent
           await confirmIntent(paymentIntent.id);
         } else {
-          // Payment succedeed
-          ScaffoldMessenger.of(context).showSnackBar(SnackBar(
-              content: Text('Error: ${paymentIntentResult['error']}')));
+          if (context.mounted) {
+            // Payment succedeed
+            scaffoldMessenger.showSnackBar(SnackBar(
+                content: Text('Error: ${paymentIntentResult['error']}')));
+          }
         }
       }
     } catch (e) {
-      ScaffoldMessenger.of(context)
-          .showSnackBar(SnackBar(content: Text('Error: $e')));
+      if (context.mounted) {
+        scaffoldMessenger.showSnackBar(SnackBar(content: Text('Error: $e')));
+      }
       rethrow;
     }
   }
 
   Future<void> confirmIntent(String paymentIntentId) async {
+    final scaffoldMessenger = ScaffoldMessenger.of(context);
     final result = await callNoWebhookPayEndpointIntentId(
         paymentIntentId: paymentIntentId);
-    if (result['error'] != null) {
-      ScaffoldMessenger.of(context)
+    if (result['error'] != null && context.mounted) {
+      scaffoldMessenger
           .showSnackBar(SnackBar(content: Text('Error: ${result['error']}')));
     } else {
-      ScaffoldMessenger.of(context).showSnackBar(SnackBar(
-          content: Text('Success!: The payment was confirmed successfully!')));
+      if (context.mounted) {
+        scaffoldMessenger.showSnackBar(SnackBar(
+            content:
+                Text('Success!: The payment was confirmed successfully!')));
+      }
     }
   }
 

diff --git a/example/lib/screens/card_payments/no_webhook_payment_screen.dart b/example/lib/screens/card_payments/no_webhook_payment_screen.dart
@@ -10,6 +10,8 @@ import 'package:stripe_example/widgets/loading_button.dart';
 import 'package:stripe_example/widgets/response_card.dart';
 
 class NoWebhookPaymentScreen extends StatefulWidget {
+  const NoWebhookPaymentScreen({super.key});
+
   @override
   _NoWebhookPaymentScreenState createState() => _NoWebhookPaymentScreenState();
 }
@@ -85,6 +87,8 @@ class _NoWebhookPaymentScreenState extends State<NoWebhookPaymentScreen> {
       return;
     }
 
+    final scaffoldMessenger = ScaffoldMessenger.of(context);
+
     try {
       // 1. Gather customer billing information (ex. email)
       final billingDetails = BillingDetails(
@@ -118,16 +122,19 @@ class _NoWebhookPaymentScreenState extends State<NoWebhookPaymentScreen> {
 
       if (paymentIntentResult['error'] != null) {
         // Error during creating or confirming Intent
-        ScaffoldMessenger.of(context).showSnackBar(
-            SnackBar(content: Text('Error: ${paymentIntentResult['error']}')));
+        if (context.mounted) {
+          scaffoldMessenger.showSnackBar(SnackBar(
+              content: Text('Error: ${paymentIntentResult['error']}')));
+        }
         return;
       }
 
       if (paymentIntentResult['clientSecret'] != null &&
-          paymentIntentResult['requiresAction'] == null) {
+          paymentIntentResult['requiresAction'] == null &&
+          context.mounted) {
         // Payment succedeed
 
-        ScaffoldMessenger.of(context).showSnackBar(SnackBar(
+        scaffoldMessenger.showSnackBar(SnackBar(
             content:
                 Text('Success!: The payment was confirmed successfully!')));
         return;
@@ -146,26 +153,33 @@ class _NoWebhookPaymentScreenState extends State<NoWebhookPaymentScreen> {
           await confirmIntent(paymentIntent.id);
         } else {
           // Payment succedeed
-          ScaffoldMessenger.of(context).showSnackBar(SnackBar(
-              content: Text('Error: ${paymentIntentResult['error']}')));
+          if (context.mounted) {
+            scaffoldMessenger.showSnackBar(SnackBar(
+                content: Text('Error: ${paymentIntentResult['error']}')));
+          }
         }
       }
     } catch (e) {
-      ScaffoldMessenger.of(context)
-          .showSnackBar(SnackBar(content: Text('Error: $e')));
+      if (context.mounted) {
+        scaffoldMessenger.showSnackBar(SnackBar(content: Text('Error: $e')));
+      }
       rethrow;
     }
   }
 
   Future<void> confirmIntent(String paymentIntentId) async {
+    final scaffoldMessenger = ScaffoldMessenger.of(context);
     final result = await callNoWebhookPayEndpointIntentId(
         paymentIntentId: paymentIntentId);
-    if (result['error'] != null) {
-      ScaffoldMessenger.of(context)
+    if (result['error'] != null && context.mounted) {
+      scaffoldMessenger
           .showSnackBar(SnackBar(content: Text('Error: ${result['error']}')));
     } else {
-      ScaffoldMessenger.of(context).showSnackBar(SnackBar(
-          content: Text('Success!: The payment was confirmed successfully!')));
+      if (context.mounted) {
+        scaffoldMessenger.showSnackBar(SnackBar(
+            content:
+                Text('Success!: The payment was confirmed successfully!')));
+      }
     }
   }
 

diff --git a/example/lib/screens/card_payments/webhook_payment_screen.dart b/example/lib/screens/card_payments/webhook_payment_screen.dart
@@ -10,6 +10,8 @@ import 'package:stripe_example/widgets/loading_button.dart';
 import 'package:stripe_example/widgets/response_card.dart';
 
 class WebhookPaymentScreen extends StatefulWidget {
+  const WebhookPaymentScreen({super.key});
+
   @override
   _WebhookPaymentScreenState createState() => _WebhookPaymentScreenState();
 }
@@ -71,6 +73,7 @@ class _WebhookPaymentScreenState extends State<WebhookPaymentScreen> {
   }
 
   Future<void> _handlePayPress() async {
+    final scaffoldMessenger = ScaffoldMessenger.of(context);
     if (_card == null) {
       return;
     }
@@ -107,9 +110,10 @@ class _WebhookPaymentScreenState extends State<WebhookPaymentScreen> {
             _saveCard == true ? PaymentIntentsFutureUsage.OffSession : null,
       ),
     );
-
-    ScaffoldMessenger.of(context).showSnackBar(SnackBar(
-        content: Text('Success!: The payment was confirmed successfully!')));
+    if (context.mounted) {
+      scaffoldMessenger.showSnackBar(SnackBar(
+          content: Text('Success!: The payment was confirmed successfully!')));
+    }
   }
 
   Future<Map<String, dynamic>> fetchPaymentIntentClientSecret() async {