Remove comments (#4293)

Signed-off-by: Omer Aplatony <[email protected]>
fluid-cloudnative · Aug 28, 2024 · 41eefb6 · 41eefb6
1 parent 6cc47b8
commit 41eefb6
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 10 deletions.
diff --git a/pkg/ddc/alluxio/transform.go b/pkg/ddc/alluxio/transform.go
@@ -48,8 +48,7 @@ func (e *AlluxioEngine) transform(runtime *datav1alpha1.AlluxioRuntime) (value *
 	value = &Alluxio{
 		Owner: transformer.GenerateOwnerReferenceFromObject(runtime),
 	}
-
-	// TODO: Handle cases that FullnameOverride is too long (> 63 chars)
+
 	value.FullnameOverride = e.name
 
 	// 1.transform the common part

diff --git a/pkg/ddc/efc/transform.go b/pkg/ddc/efc/transform.go
@@ -45,8 +45,7 @@ func (e *EFCEngine) transform(runtime *datav1alpha1.EFCRuntime) (value *EFC, err
 			Name:      runtime.Name,
 		},
 	}
-
-	// TODO: Handle cases that FullnameOverride is too long (> 63 chars)
+
 	value.FullnameOverride = e.name
 
 	err = e.transformMasters(runtime, dataset, value)

diff --git a/pkg/ddc/goosefs/transform.go b/pkg/ddc/goosefs/transform.go
@@ -44,7 +44,6 @@ func (e *GooseFSEngine) transform(runtime *datav1alpha1.GooseFSRuntime) (value *
 
 	value = &GooseFS{}
 
-	// TODO: Handle cases that FullnameOverride is too long (> 63 chars)
 	value.FullnameOverride = e.name
 
 	// 1.transform the common part

diff --git a/pkg/ddc/jindocache/transform.go b/pkg/ddc/jindocache/transform.go
@@ -118,7 +118,6 @@ func (e *JindoCacheEngine) transform(runtime *datav1alpha1.JindoRuntime) (value
 	}
 
 	value = &Jindo{
-		// TODO: Handle cases that FullnameOverride is too long (> 63 chars)
 		// TODO: refactor names of jindoruntime and make it aligned with other runtimes
 		FullnameOverride:    fmt.Sprintf("%s-%s", e.name, common.JindoChartName),
 		Image:               smartdataConfig.image,

diff --git a/pkg/ddc/jindofsx/transform.go b/pkg/ddc/jindofsx/transform.go
@@ -118,7 +118,6 @@ func (e *JindoFSxEngine) transform(runtime *datav1alpha1.JindoRuntime) (value *J
 	}
 
 	value = &Jindo{
-		// TODO: Handle cases that FullnameOverride is too long (> 63 chars)
 		// TODO: refactor names of jindoruntime and make it aligned with other runtimes
 		FullnameOverride:    fmt.Sprintf("%s-%s", e.name, common.JindoChartName),
 		Image:               smartdataConfig.image,

diff --git a/pkg/ddc/juicefs/transform.go b/pkg/ddc/juicefs/transform.go
@@ -51,7 +51,6 @@ func (j *JuiceFSEngine) transform(runtime *datav1alpha1.JuiceFSRuntime) (value *
 		},
 	}
 
-	// TODO: Handle cases that FullnameOverride is too long (> 63 chars)
 	value.FullnameOverride = j.name
 	value.Owner = transformer.GenerateOwnerReferenceFromObject(runtime)
 

diff --git a/pkg/ddc/thin/transform.go b/pkg/ddc/thin/transform.go
@@ -46,7 +46,6 @@ func (t *ThinEngine) transform(runtime *datav1alpha1.ThinRuntime, profile *datav
 		},
 	}
 
-	// TODO: Handle cases that FullnameOverride is too long (> 63 chars)
 	value.FullnameOverride = t.name
 	value.Owner = transformer.GenerateOwnerReferenceFromObject(runtime)
 	toRuntimeSetConfig, err := t.toRuntimeSetConfig(nil, nil)

diff --git a/pkg/ddc/vineyard/transform.go b/pkg/ddc/vineyard/transform.go
@@ -40,7 +40,6 @@ func (e *VineyardEngine) transform(runtime *datav1alpha1.VineyardRuntime) (value
 	value = &Vineyard{
 		Owner: transformer.GenerateOwnerReferenceFromObject(runtime),
 	}
-	// TODO: Handle cases that FullnameOverride is too long (> 63 chars)
 	value.FullnameOverride = e.name
 
 	value.TieredStore, err = e.transformTieredStore(runtime)