added explicit type cast to string to FluentRecordFormatter for exclude_attrs case.
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastak
force-pushed
the
fix/cast-to-string
branch
from
f4c4924
to
995f25e
Compare
…clude_attrs` case. Signed-off-by: Ihor Liubymov <[email protected]>
mastak
force-pushed
the
fix/cast-to-string
branch
from
995f25e
to
5538eb5
Compare
|
Sorry, no. While the intention is good, you're going to be force-casting numbers and other simple types that msgpack does support into a string as well, including arrays and dicts, which is not a valid blanket conversion (people log primitive data structures via fluent all the time). Please also see: https://github.com/msgpack/msgpack-python#packingunpacking-of-custom-data-type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case:
FluentRecordFormatterwithexclude_attrs=[].logger.info('Some info', uuid=uuid4())TypeError: can't serialize UUID('fea00603-ef79-4f11-aff5-b05ee2f68111')msgpackhas limitations for input data, so it has to be cast to simple data types.