Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tls (with InsecureSkipVerify) #37

Closed
wants to merge 1 commit into from

Conversation

soulware
Copy link

Support tls via case on FluentNetwork - tcp|tls|unix

@soulware soulware mentioned this pull request Sep 27, 2016
Closed
@tagomoris
Copy link
Member

@soulware How did you check this patch works?

@soulware
Copy link
Author

Hey @tagomoris - planning on working on getting some test coverage for this over the next couple of days. Wanted to get this on your radar early.

@tagomoris
Copy link
Member

Ah, I meant about the major use-case of this feature.
We need a kind of destination - what is that in your idea?

@soulware
Copy link
Author

If I understand your question correctly - we are intending to run fluentd with in_secure_forward plugin installed.
And host and port would be configured as necessary.
Maybe I'm not understanding your question?

@tagomoris
Copy link
Member

I think you understood my question. Thank you to answer for me.
And, currently, in_secure_forward requires handshake phase before transferring data, in addition to SSL/TLS transportation. Fluent logger libraries (there's no implementation which can do handshake) cannot send events to it.

@tagomoris
Copy link
Member

Fluentd v0.14 will have feature updates to use SSL/TLS transport layer with or without handshake protocol... now v0.14.6 has handshake(authentication) feature, but only on raw TCP.
This feature (sending events over SSL/TLS without handshake) will be useful with such coming version of Fluentd, but there's (almost) no configuration/implementation available with this feature right now.

@soulware
Copy link
Author

soulware commented Sep 28, 2016

Interesting - thanks for the info.
Alternatively we could potentially terminate SSL/TLS at the Load Balancer in AWS and use TCP from Load Balancer to Fluentd.
If we do it this way then this change to the logger would have value today?

@tagomoris
Copy link
Member

Correct. It's the reason of (almost) in my comment, and the original meaning of my first question: "did you confirm this patch works well with SSL terminator & in_forward?"

@soulware
Copy link
Author

I'm confused by "v0.14 will have feature updates" when v0.14.6 is out now. Do you mean v0.15?
Wondering if this approach is something that is still worth pursuing or if we need to rethink our approach (in terms of how we use the client logger).

@tagomoris
Copy link
Member

I'll introduce it in any version of v0.14.x (7 or 8).
This change looks good to push, but might be good to merge after the
release of Fluentd with SSL support.

2016年9月29日木曜日、Simon [email protected]さんは書きました:

I'm confused by "v0.14 will have feature updates" when v0.14.6 is out now.
Do you mean v0.15?
Wondering if this approach is something that is still worth pursuing or if
we need to rethink our approach (in terms of how we use the client logger).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#37 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOE_npX79lpASns6FDb0suy5GcyuV8Zks5qur5zgaJpZM4KICdv
.

田籠 聡 (TAGOMORI Satoshi)
Mail: [email protected]

@meirwah
Copy link

meirwah commented Nov 12, 2017

Is this PR still alive?

@sanbornm
Copy link

This PR doesn't work as is.

This line:

f.conn, err = tls.DialWithDialer(dialer, f.Config.FluentNetwork,
f.Config.FluentHost+":"+strconv.Itoa(f.Config.FluentPort),config)

Should be:

f.conn, err = tls.DialWithDialer(dialer, "tcp",
f.Config.FluentHost+":"+strconv.Itoa(f.Config.FluentPort),config)

@wfernandes
Copy link
Member

We have a need to support Fluent-bit Forward protocol via TLS. I see that the Forward Protocol for fluentd supports mutual TLS.

Or is there another golang library that supports TLS over the Forward Protocol?

Thanks.

@Manikandan-Raj
Copy link

@wfernandes , Did you find any golang library for forwarding which supports TLS ???

@wfernandes
Copy link
Member

@Manikandan-Raj We didn't. Instead we used ghostunnel as a TLS proxy between our source and fluent-bit.

@jeremy-ebler-vineti
Copy link

In 2016, there wasn't TLS support in fluentd, but today in_tcp supports native TLS.

https://docs.fluentd.org/input/tcp#less-than-transport-greater-than-section

@tagomoris tagomoris mentioned this pull request Jul 20, 2021
@zonito
Copy link
Contributor

zonito commented Nov 20, 2021

@fujimotos / @tagomoris we can close this as well. #107

@fujimotos fujimotos closed this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants