Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(decider): Refactor aqua code #83

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Oct 2, 2023

Mostly use new aqua boolean algebra

@InversionSpaces InversionSpaces requested review from folex and kmd-fl and removed request for folex October 2, 2023 09:33
@InversionSpaces InversionSpaces marked this pull request as ready for review October 2, 2023 09:33
Copy link
Collaborator

@kmd-fl kmd-fl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice but I feel there are more places where you can use the new feature. Did you want just to set an example or really want to remove the old approach?

@InversionSpaces
Copy link
Contributor Author

I am trying to bring new aqua features to all the places I could reach, so tell me if I missed some.
Yes, I am trying to set an example, and yes, I am trying to remove ugly boolean functions so that eventually we could remove them in builtin

@kmd-fl
Copy link
Collaborator

kmd-fl commented Oct 19, 2023

@InversionSpaces I just do git grep '== false' and find a lot of examples, for one, in hex.aqua

@InversionSpaces
Copy link
Contributor Author

Blocked by LNG-260

@InversionSpaces InversionSpaces merged commit 07bcd0d into main Oct 26, 2023
@InversionSpaces InversionSpaces deleted the feat/refactor-aqua branch October 26, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants