Feature/5 chakra v1 #10
Conversation
ghost
added
the
ghost
requested review from
|
@korlando7 not sure why but the preview looks pretty bad https://deploy-preview-10--maintainer-ui.netlify.app/ |
| @@ -8,13 +8,10 @@ import '../styles/main.scss' | |||
|
|
|||
| export default function Flossbank ({ Component, pageProps }) { | |||
| return ( | |||
| <ThemeProvider theme={CustomTheme}> | |||
| <CSSReset /> | |||
There was a problem hiding this comment.
can you verify this is not needed anymore? and no color mode provider either?
There was a problem hiding this comment.
Confirmed. These are both able to be removed with the V1 updates
Kev i think for the Icons they started naming their icons. so you'll have to import QuestionIcon from chakra/icons and then use that (etc etc for other icons) for custom icons i believe you have to define a custom Icon then import it, look how enterprise portal did it |
components/common/banner.js
Outdated
| @@ -22,7 +22,7 @@ const Banner = ({ icon, children, onCloseClick }) => { | |||
| > | |||
| <Icon | |||
There was a problem hiding this comment.
I believe this needs to be the CustomIcon because it seems chakra/icons doesn't have the celebration icon that we use for the banner
There was a problem hiding this comment.
I think biggest issue i've found is icons.
log in and look at the account dropdown menu (should be full of icons)
and go across pages. you should never have a "?" icon, that means that chakra can't find it.
you can look at the enterprise portal to see how we managed migrating
pages/brand-guidelines.js
Outdated
| @@ -57,7 +57,7 @@ const About = () => ( | |||
| <Button> | |||
| <Link href='/images/flossbank_logo_assets.zip' download='flossbank_icons' padding='1rem'> | |||
| Download assets | |||
| <Icon marginLeft='1rem' name='download' size='1.75rem' /> | |||
| <Icon marginLeft='1rem' name='download' w='1.75rem' h='1.75rem' /> | |||
There was a problem hiding this comment.
same here, i believe this needs to be a CustomIcon since chakra doesn't have the "download" icon. or you can see if chakra icons has a similarly looking icon
|
@stripedpajamas @joelwass fixed the icons. Let me know if you see any missing ones still. |
closes #5