-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Odin bindgen type mappings #1158
Conversation
This affects intptr_t, uintptr_t, and size_t, which are variable-sized. The previous mappings were mapped directly to 64-bit values.
This corresponds to a change in the bindgen mappings, see floooh/sokol#1157 and floooh/sokol#1158, except this function is not automatically generated.
Thanks! @jakubtomsu when you have a minute, can you also have a look in case you have any objections? (also at: floooh/sokol-odin#22) |
Looks like at least one sample needs to be fixed as well:
...but that may be a chicken egg problem (e.g. first commit this MR to update the bindings, then fix the sample(s)). |
yep, looking at the code everything seems fine. |
Should I update the |
I think that makes sense, even if it might not compile until the sokol PR is merged. |
Oki thanks for the PRs. I'm currently busy working an unrelated sokol PR, but I'll try to get this stuff merged tomorrow. |
...and that one also merged, watching the CI pipeline out if everything looks in order... |
...also thanks for the PR! :) |
This affects
intptr_t
,uintptr_t
, andsize_t
, which are variable-sized. The previous mappings were mapped directly to 64-bit values, and they've been changed to use the correspondingcore:c
aliases.This closes #1157. An additional fix is required in
sokol-odin
itself to correcthelpers.Allocator.alloc_fn
, which usesu64
for asize_t
argument.