Add NDEBUG flag to non-debug builds #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the performance of web builds was terrible due to a lot of calls to glGetError, which as far as I can tell shouldn't be called in release builds at all. Turns out
SOKOL_DEBUG
is defined even when using-Doptimize=ReleaseSafe
. I may be missing something obvious, but shouldn'tNDEBUG
be defined in this case? 👀