Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial testing for OF-DPA 2.0 #189

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

capveg
Copy link

@capveg capveg commented Jul 22, 2015

OF-DPA has a custom hardware pipeline and most OFTest tests assume
that any table will accept any match (which is not true!).
FYI:

./oft -V1.3 --test-dir=tests-ofdpa-2.0 to run all of the OFDPA tests

Known working tests:

ipv6_fwd
PacketInExact

Reviewer: @rlane @rizard

OF-DPA has a custom hardware pipeline and most OFTest tests assume
that any table will accept any match (which is not true!).

Trying to initially port basic.PacketInExact.  Many pure control
plane tests work out of the box.

Lots of non-working tests.

FYI:

`./oft  -V1.3 --test-dir=tests-ofdpa-2.0` to run all of the OFDPA tests
@bsn-abat
Copy link

ABAT: AUTO-REJECT: no reviewer specified in pull request description

INSTRUCTIONS: Please fix your problem by

  1. Make sure line below is included in pull request description (not a follow-up comment):
    Reviewer: @ExampleUser1 @ExampleUser2 @exampleuser3 ...
    Leave no space at beginning of line. Use real GitHub IDs as reviewers.

  2. Have at least one approval in any follow-up comment. An approval is given by including a single word of "ACK" (without quotes) in a line by itself. The approval can come from any person except the requester.

Under certain situations the requester can approve his/her own change. To do that, just include a single word of "SELF-ACK" (without quotes) in a line by itself. You are trusted not to abuse it :)

Any code review approval or new comment including the magic line of "R_E_T_R_Y" (Remove the underscores) will cause abat to automatically try to merge your code again.

Rob Sherwood added 8 commits July 24, 2015 17:09
With OF-DPA, you need two flow_mods per port to do 'VLAN access' mode.

basic.PacketInExact and basic.PacketInWildcard now working

basic.AggregateStats ... ok
basic.AsyncConfigGet ... ERROR
basic.DefaultDrop ... ok
basic.DescStats ... ok
basic.Echo ... ok
basic.EchoWithData ... ok
basic.FeaturesRequest ... ok
basic.FlowRemoveAll ... ok
basic.FlowStats ... ok
basic.GroupDescStats ... ok
basic.GroupFeaturesStats ... ERROR
basic.GroupStats ... ok
basic.MeterConfigStats ... FAIL
basic.MeterFeaturesStats ... ERROR
basic.MeterStats ... FAIL
basic.OutputExact ... FAIL
basic.OutputWildcard ... FAIL
basic.PacketInExact ... ok
basic.PacketInMiss ... FAIL
basic.PacketInWildcard ... ok
basic.PacketOut ... ok
basic.PortConfigMod ... ok
basic.PortDescStats ... ok
basic.PortStats ... ok
basic.QueueStats ... ok
basic.TableStats ... ok
Insert new groups at each iteration
Set ofdpa.dataplane.MATCH_VERBOSE to True
Two caveats:
* running the test back to back triggers a bug in the 'delete all groups'
    logic.  Need to fix.

* I think I observed this working most times but not always.  I think
    it was an OF-DPA setup problem but could in theory be a race
    condition or other error with the test.  TBD.
@capveg
Copy link
Author

capveg commented Jul 30, 2015

Retry

Rob Sherwood added 2 commits August 3, 2015 08:53
Was working for OFDPA 2.0 EA1 but stops working on OFDPA 2.0 EA2
Also added a ipv6 tagged test.

There is pathological code in the untagged VLAN case.
@capveg
Copy link
Author

capveg commented Aug 28, 2015

@rlane : do you have time to take a look at/review this?

@ExampleUser1
Copy link

@capveg : Don't use "@ExampleUser1" anymore, please. I don't want to get a new messages on email.

self.dst_ip = dst_ip


@group('ipv6_fwd')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are by default included in a group named after the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants