Adds inWithTransaction helper to get transaction status
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gera-cameron
approved these changes
Nov 20, 2024
jlavelle
force-pushed
the
nebula/add-in-transaction-helper
branch
from
27008f3 to
43e5410
Compare
telser
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Only nit left to pick is that it might be helpful to have some haddocks for what the Natural in the InSavepointTransaction is for/about.
Not a blocker for this PR by any means. Also, I'd like to do another haddock sweep before cutting 1.1.0.0 and it can be added then.
jlavelle
force-pushed
the
nebula/add-in-transaction-helper
branch
from
43e5410 to
78da1b4
Compare
I added a function that will return a new type called `InWithTransaction` when called within the action passed to `withTransaction`. The value indicates whether the transaction is the outermost, or is within a savepoint.
jlavelle
force-pushed
the
nebula/add-in-transaction-helper
branch
from
78da1b4 to
53b4d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a function that will return a new type called
InWithTransactionwhen called within the action passed towithTransaction. The value indicates whether the transaction is the outermost, or is within a savepoint.