Adds ConnectionOptions for createConnectionPool parameters
#337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing a `ConnectionOptions` record should be a better experience for anyone trying to read the docs or look at example code. This also adds a `StripeOption` type that allows users to easily get one stripe allocated per thread capability, which is what is recommended by `resource-pool`.
onslaughtq
approved these changes
Oct 27, 2023
telser
reviewed
Oct 27, 2023
|
|
||
| {- | | ||
| Allocates a connection from the pool and performs an action with it. This | ||
| function will block if the maximum number of connections is reached. |
There was a problem hiding this comment.
Missing the since annotation here.
telser
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing a
ConnectionOptionsrecord should be a better experience foranyone trying to read the docs or look at example code. This also adds a
StripeOptiontype that allows users to easily get one stripe allocatedper thread capability, which is what is recommended by
resource-pool.