remove Show constraint; there are issues to be fixed

try example eskimor#89 (comment)
flip111 · Feb 25, 2024 · aabc5d4 · aabc5d4
1 parent 5c86b32
commit aabc5d4
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/example/src/Argonaut/Types.purs b/example/src/Argonaut/Types.purs
@@ -118,7 +118,7 @@ instance (DecodeJson a, DecodeJsonField a) => DecodeJson (Bar a) where
 
 
 
-instance (Show a) => Show (Bar a) where
+instance Show (Bar a) where
   show a = genericShow a
 
 derive instance Generic (Bar a) _

diff --git a/example/src/JsonHelpers/Types.purs b/example/src/JsonHelpers/Types.purs
@@ -143,7 +143,7 @@ instance (DecodeJson a, DecodeJsonField a) => DecodeJson (Bar a) where
 
 
 
-instance (Show a) => Show (Bar a) where
+instance Show (Bar a) where
   show a = genericShow a
 
 derive instance Generic (Bar a) _

diff --git a/src/Language/PureScript/Bridge/Printer.hs b/src/Language/PureScript/Bridge/Printer.hs
@@ -365,8 +365,9 @@ eqConstraints = constrainWith "Eq"
 ordConstraints :: PSType -> [PSType]
 ordConstraints = constrainWith "Ord"
 
+-- https://github.com/eskimor/purescript-bridge/pull/89#issuecomment-1890994859
 showConstraints :: PSType -> [PSType]
-showConstraints = constrainWith "Show"
+showConstraints _ = mempty -- constrainWith "Show"
 
 decodeJsonConstraints :: PSType -> [PSType]
 decodeJsonConstraints psType =

diff --git a/test/RoundTripArgonautAesonGeneric/app/src/RoundTripArgonautAesonGeneric/Types.purs b/test/RoundTripArgonautAesonGeneric/app/src/RoundTripArgonautAesonGeneric/Types.purs
@@ -123,7 +123,7 @@ derive instance (Eq a) => Eq (TestRecord a)
 
 derive instance (Ord a) => Ord (TestRecord a)
 
-instance (Show a) => Show (TestRecord a) where
+instance Show (TestRecord a) where
   show a = genericShow a
 
 instance (EncodeJson a) => EncodeJson (TestRecord a) where

diff --git a/test/RoundTripJsonHelpers/app/src/RoundTripJsonHelpers/Types.purs b/test/RoundTripJsonHelpers/app/src/RoundTripJsonHelpers/Types.purs
@@ -220,7 +220,7 @@ derive instance (Eq a) => Eq (TestRecord a)
 
 derive instance (Ord a) => Ord (TestRecord a)
 
-instance (Show a) => Show (TestRecord a) where
+instance Show (TestRecord a) where
   show a = genericShow a
 
 instance (EncodeJson a) => EncodeJson (TestRecord a) where