-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using productID instead of name #15
Open
jsb2092
wants to merge
31
commits into
flifloo:master
Choose a base branch
from
jetcom:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for using Product ID instead of name
Changed to use productIdentifier instead of name
Fixed using ID
Using product_id_map
Fixed spelling of product
Added support for product_id_map
More changes to use ID
Fixes issue #14 |
trying truncating again Update feeder.py Truncate amount to 2 decimal points Update feeder.py truncated to 2 decimal points, changed cup to cups Update feeder.py trying again
This reverts commit a586cc4.
attempting to add fountain support adding sensors for fountain fixed sensor class adding weight percent added labels for water fixing labels trying to get the water today to show up trying a device class fixing units for volume fixing stuff fixed unit converstion changed device types adding %, I think Trying to get the % label to show trying to refresh water data correctly attempt to get fountain to refresh still trying to get it to regresh
This reverts commit 9b70158.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #14