Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tapes human readable based on content-type and content-enconding #18

Closed
wants to merge 1 commit into from
Closed

Make tapes human readable based on content-type and content-enconding #18

wants to merge 1 commit into from

Conversation

ijpiantanida
Copy link
Contributor

@ijpiantanida ijpiantanida commented May 23, 2016

Proposal for #2.

There's a whitelist of content-types that are considered human readable.
If the content-type is human readable and the request body is in plain text
(no content-enconding header or content-enconding == identity) then the
body is saved in UTF-8. Otherwise, keep using base64.

More work can be done on this feature (like decompressing the body based on the content-enconding used and then re-compressing when serving the tape) but I'd first like to check what do you think about this approach.

@mwolson
Copy link

mwolson commented Aug 5, 2016

Hey all, wanted to bump this since we're getting some further feedback from other folks inside Ticcketmaster who would like to see this in order to increase adoption.

@eadmundo
Copy link

this would be great to get into an npm release - is this project still being maintained by flickr though? last commit to master was Aug 2016. @jeremyruppel ?

@Monte9
Copy link

Monte9 commented Jan 31, 2019

Can we please get this merged in? Trying to decode every request is pretty cumbersome

If not, is there a fork out there that has these changes? I'd be happy to switch over as this repo doesn't seem to be maintained anymore.

@yahoocla
Copy link

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@Monte9
Copy link

Monte9 commented Jan 31, 2019

Update: Ended up using a replacement library called Talkback.

More on it here: #49

@jeremyruppel jeremyruppel deleted the branch flickr:master October 29, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants