Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to change tizen certificate from default RNV to custom ones #1734

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

justinasRm
Copy link
Contributor

@justinasRm justinasRm commented Sep 27, 2024

Description

  • Currently if a user wants to use a custom tizen certificate, he can manaully change it//add it in appConfigs/app/renative.json platforms.tizen, platforms.tizenmobile or platforms.tizenwatch objects, certificateProfile key. But it still checks for the default RNV certificate in some places (first photo - running rnv run -p tizen. Checks for RNVanillaCert at the start of it, even though it was changed to custom certificate fakeCert, in renative.json, which is visible in the second picture in the CLI command).
Screenshot 2024-09-27 at 07 47 56 Screenshot 2024-09-27 at 07 48 45

For testing:
Added new command for tizen:
npx rnv tizen certificate it change default certificate to the new custom one

Related issues

Npm releases

n/a

@justinasRm justinasRm added this to the 1.4 milestone Sep 27, 2024
@justinasRm justinasRm self-assigned this Sep 27, 2024
@justinasRm justinasRm changed the title Being able to change tizen certificate from RNV tu Being able to change tizen certificate from default RNV to custom ones Sep 27, 2024
@justinasRm justinasRm marked this pull request as draft September 27, 2024 04:52
@Marius456 Marius456 added the e2e label Sep 27, 2024
@justinasRm justinasRm marked this pull request as ready for review September 27, 2024 09:53
@Marius456 Marius456 added e2e and removed e2e labels Sep 29, 2024
@Marius456 Marius456 self-assigned this Sep 30, 2024
Copy link
Collaborator

@GabrieleKaceviciute GabrieleKaceviciute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after yarn bootstrap-clean doesn't work ->

➜  template-starter git:(fix/tizen-change-certificates) npx rnv tizen certificate

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ 🚀 v:1.3.0-rc.0 | renative.org | 9/30/2024, 2:15:36 PM          │
│ $ rnv tizen certificate                                         │
└─────────────────────────────────────────────────────────────────┘
info: Current engine: @rnv/engine-rn-web (../engine-rn-web)
task: ○ tizen certificate ↺1
task: ✔ tizen certificate
┌─────────────────────────────────────────────────────────────────┐
│ ✔ SUMMARY | 9/30/2024, 2:15:36 PM | [email protected]              │
│ $ rnv tizen certificate                                         │
├─────────────────────────────────────────────────────────────────┤
│ Project: @rnv/[email protected]                       │
│ Workspace: rnv                                                  │
│ Engine: @rnv/engine-rn-web                                      │
│ Build Scheme (-s): debug                                        │
│ Env Info: darwin | arm64 | node v18.19.0                        │
│ Executed Time: 0h:0m:0s:149ms                                   │
└─────────────────────────────────────────────────────────────────┘
➜  template-starter git:(fix/tizen-change-certificates)

Note:
After npx rnv build -p tizen -> works

➜  template-starter git:(fix/tizen-change-certificates) npx rnv build -p tizen

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ 🚀 v:1.3.0-rc.0 | renative.org | 9/30/2024, 2:06:42 PM          │
│ $ rnv build -p tizen                                            │
└─────────────────────────────────────────────────────────────────┘
info: Current engine: @rnv/engine-rn-web (../engine-rn-web)
task: ○ build ↺1
info: Build hooks not complied. BUILDING...
task: ○ configure ↺1
task: ○ platform configure ↺1
task: ○ project configure ↺1
info: Creating folder ./platformBuilds ...DONE
task: ○ workspace configure ↺1
task: ✔ workspace configure
task: ○ app configure ↺1
? Which one would you like to pick? template
info: Current app config: template
warn: ○ project configure: Updates to package.json are required: (only info. skipping due to template mode)
- dotenv (N/A) => (16.4.5) Missing dependency for platform ios | engine.npm (@rnv/engine-rn)
- dotenv (N/A) => (16.4.5) Missing dependency for platform tvos | engine.npm (@rnv/engine-rn-tvos)
- raf (N/A) => (3.4.1) Missing dependency for platform tizen | engine.npm (@rnv/engine-rn-web)

task: ✔ app configure
info: ✔ ../../node_modules/@react-native-community/cli-platform-ios/build/tools/listIOSDevices.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli-platform-ios/[email protected]. FIXING...DONE
info: ✔ ../../node_modules/@react-native-community/cli-platform-ios/build/tools/listIOSDevices.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli-platform-ios/[email protected]. FIXING...DONE
info: ✔ ../../node_modules/@react-native-community/cli-platform-ios/build/commands/runIOS/index.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli-platform-ios/[email protected]. FIXING...DONE
info: ✔ ../../node_modules/@react-native-community/cli/build/bin.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli/overrides.json. FIXING...DONE
info: ✔ ../../node_modules/react-native/node_modules/@react-native-community/cli/build/bin.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli/overrides.json. FIXING...DONE
info: ✔ ../../node_modules/react-native-tvos/node_modules/@react-native-community/cli/build/bin.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli/overrides.json. FIXING...DONE
info: ✔ ../../node_modules/react-native-tvos/Libraries/Components/ScrollView/ScrollViewNativeComponent.js requires override by: /@rnv/config-templates/pluginTemplates/react-native-tvos/overrides.json. FIXING...DONE
info: ✔ ../../node_modules/react-native-tvos/Libraries/Components/ScrollView/ScrollViewNativeComponent.js requires override by: /@rnv/config-templates/pluginTemplates/react-native-tvos/overrides.json. FIXING...DONE
info: ✔ ../../node_modules/react-native-tvos/Libraries/Components/ScrollView/ScrollViewNativeComponent.js requires override by: /@rnv/config-templates/pluginTemplates/react-native-tvos/overrides.json. FIXING...DONE
task: ✔ project configure
info: Current Build Scheme: debug
task: ○ sdk configure ↺1
task: ✔ sdk configure
task: ✔ platform configure
✔ Executing: "/Users/gabriele/tizen-studio/tools/ide/bin/tizen" security-profiles list -n RNVanillaCert
info: Found custom assetSources at ../../node_modules/@flexn/assets-renative-outline/assets/tizen. Will be used to generate assets.
task: ✔ configure
info: File sizes after gzip:

  181.84 kB  build/static/js/main.1388552d.js
The project was built assuming it is hosted at ./.
You can control this with the homepage field in your package.json.

The platformBuilds/template_tizen/build folder is ready to be deployed.

Find out more about deployment here:

  https://cra.link/deployment

✔ Executing: "/Users/gabriele/tizen-studio/tools/ide/bin/tizen" build-web -- "/Users/gabriele/Desktop/tests/renative/packages/template-starter/platformBuilds/template_tizen/build" -out "/Users/gabriele/Desktop/tests/renative/packages/template-starter/platformBuilds/template_tizen/intermediate"
✔ Executing: "/Users/gabriele/tizen-studio/tools/ide/bin/tizen" package -- "/Users/gabriele/Desktop/tests/renative/packages/template-starter/platformBuilds/template_tizen/intermediate" -s RNVanillaCert -t wgt -o "/Users/gabriele/Desktop/tests/renative/packages/template-starter/platformBuilds/template_tizen/output"
info: ✔ Your WGT package is located in ./platformBuilds/template_tizen/output .
task: ✔ build
┌─────────────────────────────────────────────────────────────────┐
│ ⚠ SUMMARY | 9/30/2024, 2:07:00 PM | [email protected]              │
│ $ rnv build -p tizen                                            │
├─────────────────────────────────────────────────────────────────┤
│ Project: @rnv/[email protected]                       │
│ Workspace: rnv                                                  │
│ Platform (-p): tizen                                            │
│ Engine: @rnv/engine-rn-web                                      │
│ Template: @rnv/template-starter                                 │
│ App Config (-c): template                                       │
│ Build Scheme (-s): debug                                        │
│ Target (-t): T-samsung-8.0-x86                                  │
│ Supported Platforms: ios, android, androidtv, firetv, androidwear, web, tizen, tvos, webos, macos, tizenwatch, kaios, chromecast, linux, windows
│ Env Info: darwin | arm64 | node v18.19.0                        │
│ Executed Time: 0h:0m:18s:15ms                                   │
│ warn: ○ project configure: Updates to package.json are required: (only info. skipping due to template mode)
│ info: ✔ ../../node_modules/@react-native-community/cli-platform-ios/build/tools/listIOSDevices.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli-platform-ios/[email protected]. FIXING...DONE
│ info: ✔ ../../node_modules/@react-native-community/cli-platform-ios/build/commands/runIOS/index.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli-platform-ios/[email protected]. FIXING...DONE
│ info: ✔ ../../node_modules/@react-native-community/cli/build/bin.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli/overrides.json. FIXING...DONE
│ info: ✔ ../../node_modules/react-native/node_modules/@react-native-community/cli/build/bin.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli/overrides.json. FIXING...DONE
│ info: ✔ ../../node_modules/react-native-tvos/node_modules/@react-native-community/cli/build/bin.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli/overrides.json. FIXING...DONE
│ info: ✔ ../../node_modules/react-native-tvos/Libraries/Components/ScrollView/ScrollViewNativeComponent.js requires override by: /@rnv/config-templates/pluginTemplates/react-native-tvos/overrides.json. FIXING...DONE
│ info: ✔ Your WGT package is located in ./platformBuilds/template_tizen/output .
│ Project location: ./platformBuilds/template_tizen               │
└─────────────────────────────────────────────────────────────────┘
➜  template-starter git:(fix/tizen-change-certificates) npx rnv tizen certificate

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ 🚀 v:1.3.0-rc.0 | renative.org | 9/30/2024, 2:07:04 PM          │
│ $ rnv tizen certificate                                         │
└─────────────────────────────────────────────────────────────────┘
info: Current engine: @rnv/engine-rn-web (../engine-rn-web)
task: ○ tizen certificate ↺1
? Tizen - used certificate change. NOTE: you must create the certificate first through the tizens certificate-manager. Continue? Yes
? For which platform do you want to set the new certificate? tizen
? Enter the new certificate name: qwe
task: ✔ tizen certificate
┌─────────────────────────────────────────────────────────────────┐
│ ✔ SUMMARY | 9/30/2024, 2:07:52 PM | [email protected]              │
│ $ rnv tizen certificate                                         │
├─────────────────────────────────────────────────────────────────┤
│ Project: @rnv/[email protected]                       │
│ Workspace: rnv                                                  │
│ Engine: @rnv/engine-rn-web                                      │
│ App Config (-c): template                                       │
│ Build Scheme (-s): debug                                        │
│ Env Info: darwin | arm64 | node v18.19.0                        │
│ Executed Time: 0h:0m:48s:481ms                                  │
└─────────────────────────────────────────────────────────────────┘
➜  template-starter git:(fix/tizen-change-certificates)

@Marius456 Marius456 added e2e and removed e2e labels Sep 30, 2024
@GabrieleKaceviciute GabrieleKaceviciute self-requested a review October 1, 2024 06:53
@Marius456 Marius456 merged commit 9f9c2a0 into main Oct 1, 2024
13 checks passed
@Marius456 Marius456 deleted the fix/tizen-change-certificates branch October 1, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants