Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP unit test for generateBVHModel from primitives #311

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

WIP unit test for generateBVHModel from primitives #311

wants to merge 24 commits into from

Commits on Jul 5, 2018

  1. Add GenerateBVHSubModel variants 

    Identical to the GenerateBVHModel, but without ending the model, such that
more geometric primitives can be added. This is useful if you want to
create a BVHModel containing multiple geometric primitives.
    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    d9cf0be View commit details
    Browse the repository at this point in the history

  2. Refactor to use boolean to choose submodel 

    This commit refactors the generateBVHModel() functions to use
an additional boolean argument to chose whether the geometric
primitive should be added to an existing model. This seems
a bit cleaner than the previously added "generateBVHSubModel"
variants.
    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    4753f47 View commit details
    Browse the repository at this point in the history

  3. Add doxygen group comments and change boolean name 

    In response to Michael Sherman's comments. Should be more clear now
    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    cd683c2 View commit details
    Browse the repository at this point in the history

  4. Use enum class instead of boolean 

    This is needed to avoid implicit casts from unsigned int that
would render the overload resolution impossible.
    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    65aa330 View commit details
    Browse the repository at this point in the history

  5. Clearer naming of total triangle variable 

    In generateBVHModel for a cylinder and cone, total actually represents
the total number of triangles of the bottom or top plate, not
the total triangles of the entire primitive (as opposed to the other
generateBVHModel variants)
    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    de29f8f View commit details
    Browse the repository at this point in the history

  6. Add unit tests for generateBVHModel

    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    5184591 View commit details
    Browse the repository at this point in the history

  7. Remove some hardcoding in unit test

    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    72a7dd6 View commit details
    Browse the repository at this point in the history

  8. Remove hardcoding in testEllipsoid

    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    0ba7815 View commit details
    Browse the repository at this point in the history

  9. Remove hardcoding in testSphere

    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    5f407e9 View commit details
    Browse the repository at this point in the history

  10. Improve TestBox

    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    e15642f View commit details
    Browse the repository at this point in the history

  11. Change loop ordering in for performance 

    So we can pull out a loop invariant
    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    685b917 View commit details
    Browse the repository at this point in the history

  12. Add casts to remove compiler warnings

    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    2a34839 View commit details
    Browse the repository at this point in the history

  13. Formatting and whitespace

    Nico van Duijn committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    72131a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2018

  1. More elaborate comments

    Nico van Duijn committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    eeab6b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2018

  1. Better comments and addTriangles() function

    Nico van Duijn committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    7361dfa View commit details
    Browse the repository at this point in the history

  2. Refactor test to use checkNumVerticesAndTris

    Nico van Duijn committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    45647be View commit details
    Browse the repository at this point in the history

  3. Add error handling to generateBVHModel

    Nico van Duijn committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    beb1009 View commit details
    Browse the repository at this point in the history

  4. Add test for adding to closed models

    Nico van Duijn committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    77a119b View commit details
    Browse the repository at this point in the history

  5. Range based for loops in testBVHModel

    Nico van Duijn committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    3dcafd8 View commit details
    Browse the repository at this point in the history

  6. Better commenting

    Nico van Duijn committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    7c11d0d View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2018

  1. Refactor unit tests for generateBVHModel 

    Includes response to PR review, with minor comment fixes
as well as a major refactor in the unit test function.
    Nico van Duijn committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    e54d832 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Add hard-coding in unit test for box

    Nico van Duijn committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    943b65e View commit details
    Browse the repository at this point in the history

  2. Remove unit test for primitive generation

    Nico van Duijn committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    3a480ac View commit details
    Browse the repository at this point in the history

  3. WIP add unit test for primitive generation 

    WIP

This reverts commit 3a480ac.
Essentially adding the bare bones for a unit test that ensures
proper BVHModel generation from geometric primitives. So far
this test only checks the number of vertices and triangles, which
is insufficient to assert proper functionality of the
generateBVHModel() functions.
    Nico van Duijn committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    e2ce071 View commit details
    Browse the repository at this point in the history