Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL-1401 - New Template: Shared Cost Reallocation - AWS Support #2776

Closed
wants to merge 19 commits into from

Conversation

bryankaraffa
Copy link
Contributor

Description

This policy template reallocates AWS Support costs (OCBPremiumSupport, AWSEnterpriseSupport, AWSSupportBusiness, AWSSupportEnterprise) to the AWS Linked Accounts within the AWS Organization. Costs are allocated to each AWS Linked Account based on the percentage of total that account consumed in the bill period.

To reallocate the costs, the policy template uses Flexera's "Common Bill Ingest" (CBI) capability to negate the original cost allocated to the AWS Master Payer Account with negative cost line items, and write the reallocation portional costs as new line items.

Issues Resolved

https://flexera.atlassian.net/browse/POL-1401

Link to Example Applied Policy

Contribution Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable
  • New functionality has been documented in CHANGELOG.MD

Copy link
Contributor

github-actions bot commented Oct 23, 2024

1 Error
🚫

operational/aws/shared_cost_reallocation/aws_support/shared_cost_reallocation_aws_support.pt

Policy Template has console.log() statements. These are used for debugging and should not be present in catalog policy templates:

Line 655
Line 665
Line 739
Line 749
Line 783
Line 784
Line 785
Line 874
Line 884
Line 958
Line 968

2 Warnings
⚠️

Important Files Modified

Please make sure these modifications were intentional and have been tested. These files are necessary for configuring the Github repository and managing automation.

.spellignore

⚠️

operational/aws/shared_cost_reallocation/aws_support/shared_cost_reallocation_aws_support.pt

Detected new request datasource(s) in Policy Template file. Please verify the README.md has any new permissions that may be required.

Generated by 🚫 Danger

@bryankaraffa bryankaraffa changed the title POL-1401 - New PT: Shared Cost Reallocation - AWS Support POL-1401 - New Template: Shared Cost Reallocation - AWS Support Oct 23, 2024
XOmniverse

This comment was marked as resolved.

@bryankaraffa bryankaraffa requested review from XOmniverse and a team October 24, 2024 02:09
@bryankaraffa
Copy link
Contributor Author

Policy Template has console.log() statements. These are used for debugging and should not be present in catalog policy templates

These are false positives from logSample usage... we may want to sync how we want to move forward on this as I think it's something we will want to use in other PTs

@bryankaraffa bryankaraffa requested review from nia-vf1 and a team October 30, 2024 22:08
@bryankaraffa
Copy link
Contributor Author

bryankaraffa commented Oct 30, 2024

We have 2 customers so far who have deployed this, validated the outcome, and are moving forward with backfilling historical cost data.

Biggest issue we are encountering is policy execution timeout limits (30m) in some of the larger tenants we are testing in. Could be mitigated/prevented by increasing policy timeout limit globally or per-org.

nia-vf1
nia-vf1 previously approved these changes Oct 31, 2024
Copy link
Contributor

@nia-vf1 nia-vf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nia-vf1
Copy link
Contributor

nia-vf1 commented Oct 31, 2024

Adding "DO-NOT-MERGE" label as per Bryan's comment above. We want to do some more testing potentially on a smaller customer at daily granularity

Other than that, the PR looks good. We may want to consider removing console.logs from the policy template when we are happy and ready to publish to the Catalog

@bryankaraffa bryankaraffa requested review from nia-vf1 and a team November 8, 2024 00:24

## What It Does

This policy template reallocates AWS Support costs (`OCBPremiumSupport`, `AWSEnterpriseSupport`, `AWSSupportBusiness`, `AWSSupportEnterprise`) to the AWS Linked Accounts within the AWS Organization. Costs are allocated to each AWS Linked Account based on the percentage of total that account consumed in the bill period.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This policy template reallocates AWS Support costs (`OCBPremiumSupport`, `AWSEnterpriseSupport`, `AWSSupportBusiness`, `AWSSupportEnterprise`) to the AWS Linked Accounts within the AWS Organization. Costs are allocated to each AWS Linked Account based on the percentage of total that account consumed in the bill period.
This policy template reallocates AWS Support costs (`OCBPremiumSupport`, `AWSEnterpriseSupport`, `AWSSupportBusiness`, `AWSSupportEnterprise`) to the AWS Linked Accounts within the AWS Organization. Costs are allocated to each AWS Linked Account based on the percentage of the total that account consumed in the bill period.

@bryankaraffa bryankaraffa force-pushed the POL-1401/bk_aws_support_cost_reallocation branch from af2b7ed to 85e3a91 Compare December 12, 2024 17:47
@bryankaraffa bryankaraffa force-pushed the POL-1401/bk_aws_support_cost_reallocation branch from 85e3a91 to b55f9d6 Compare December 20, 2024 00:07
@bryankaraffa bryankaraffa force-pushed the POL-1401/bk_aws_support_cost_reallocation branch from b55f9d6 to 3e61ff0 Compare January 7, 2025 02:18
@bryankaraffa
Copy link
Contributor Author

Closing this branch/PR in favor of superseded one that includes the other cost reallocation PTs that were done as part of this epic: #2933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants