Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL-1298 - Flexera Onboarding v0.1.0 #2450

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

bryankaraffa
Copy link
Contributor

Description

This policy checks various configurations in your Organization to ensure that it is set up correctly. The checks and recommendations are opinionated, and align with recommended best practices for onboarding and productionizing your Organization.

Issues Resolved

https://flexera.atlassian.net/browse/POL-1298

Link to Example Applied Policy

https://app.flexera.com/orgs/6/automation/applied-policies/projects/7954?policyId=669acdc8a09cd9483203663e

Contribution Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable
  • New functionality has been documented in CHANGELOG.MD

@bryankaraffa bryankaraffa added the enhancement New feature or request label Jul 22, 2024
@bryankaraffa bryankaraffa requested a review from a team as a code owner July 22, 2024 18:28
@bryankaraffa bryankaraffa changed the title New Template: Flexera Onboarding v0.1.0 POL-1298 - New Template: Flexera Onboarding v0.1.0 Jul 22, 2024
Copy link
Contributor

github-actions bot commented Jul 22, 2024

1 Error
🚫

operational/flexera/onboarding/flexera_onboarding.pt

Flexera policy is not contained in a subdirectory specific to the Flexera service it is for. For example, Flexera CCO cost policies should be in the /cost/flexera/cco subdirectory.


Policy Template has console.log() statements. These are used for debugging and should not be present in catalog policy templates:

Line 570
Line 609
Line 613
Line 617
Line 626
Line 1270

2 Warnings
⚠️

Important Files Modified

Please make sure these modifications were intentional and have been tested. These files are necessary for configuring the Github repository and managing automation.

.spellignore

⚠️

operational/flexera/onboarding/flexera_onboarding.pt

Detected new request datasource(s) in Policy Template file. Please verify the README.md has any new permissions that may be required.

Generated by 🚫 Danger

@bryankaraffa bryankaraffa requested a review from a team August 9, 2024 16:08
@bryankaraffa bryankaraffa force-pushed the feat/POL-1298_new_pt_flexera_onboarding branch from 1390ba7 to 8ac8846 Compare August 15, 2024 18:32
@nia-vf1 nia-vf1 assigned bryankaraffa and unassigned nia-vf1 Aug 30, 2024
@bryankaraffa bryankaraffa force-pushed the feat/POL-1298_new_pt_flexera_onboarding branch from 61c646a to 9021cea Compare September 9, 2024 16:04
nia-vf1
nia-vf1 previously approved these changes Nov 8, 2024
Copy link
Contributor

@nia-vf1 nia-vf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryankaraffa bryankaraffa changed the title POL-1298 - New Template: Flexera Onboarding v0.1.0 POL-1298 - Flexera Onboarding v0.1.0 Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants