-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Flutter IconData
class
#4696
Open
omamkaz
wants to merge
23
commits into
flet-dev:main
Choose a base branch
from
omamkaz:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: `IconData` class support.
Changed: attr `name` into `icon` to support the `IconData` class.
Added: `IconData` to `IconValue`
Added: `_set_attr_icon` method to send icon data.
Changed: the `name` property into `icon` to send icon data. Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Added: `IconData` support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added: Flutter
IconData
class to implement custom icons in each control supportingIconValue
IconData -> https://api.flutter.dev/flutter/widgets/IconData-class.html
Building
Test Code
Type of change
Checklist
Screenshots
Additional details
Summary by Sourcery
Add support for custom icons using the new
IconData
class. This allows developers to specify icons from custom fonts by providing the code point, font family, and other relevant properties. Update all relevant controls and methods to supportIconData
.New Features:
IconData
class to define custom icons from arbitrary fonts.Tests:
IconData
.