Feature/task run model #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psykar
force-pushed
the
feature/task-run-model
branch
from
5dc4f53 to
8d90730
Compare
dtkav
reviewed
Mar 2, 2019
config/settings/base.py
Outdated
| @@ -279,3 +279,6 @@ def immutable_file_test(path, url): | |||
|
|
|||
|
|
|||
| WHITENOISE_IMMUTABLE_FILE_TEST = immutable_file_test | |||
|
|
|||
| S3_FILE_BUCKET = env.str('DJANGO_S3_FILE_BUCKET') | |||
There was a problem hiding this comment.
I'd recommend replacing these with a single URI.
This would allow the use of "/tmp/data" for local, and "s3://my_bucket/some/path" down the line.
There was a problem hiding this comment.
Haven't implemented local storage yet (as that would require an endpoint to accept file data, instead of just metadata) but have generalized to remove references to bucket, and detect s3:// urls.
dtkav
reviewed
Mar 2, 2019
dtkav
reviewed
Mar 2, 2019
dtkav
reviewed
Mar 2, 2019
dtkav
reviewed
Mar 2, 2019
dtkav
reviewed
Mar 2, 2019
dtkav
reviewed
Mar 2, 2019
dtkav
reviewed
Mar 2, 2019
Psykar
force-pushed
the
feature/task-run-model
branch
from
8d90730 to
d14c8e5
Compare
|
I believe I've addressed everything, would welcome another look :) |
dtkav
reviewed
Mar 4, 2019
dtkav
reviewed
Mar 4, 2019
dtkav
reviewed
Mar 4, 2019
dtkav
reviewed
Mar 4, 2019
Psykar
force-pushed
the
feature/task-run-model
branch
from
625fc9f to
122676e
Compare
Psykar
force-pushed
the
feature/task-run-model
branch
3 times, most recently
from
202a570 to
c236d0e
Compare
|
@dtkav worth one more look over - I think this is in a decent state :) |
Otherwise postgres server itself doesn't get started.
Adds a TaskRun and a File model for storing results of task which have been run. Allows uploading of stdout / stderr to S3.
To better match the rest of the API.
Psykar
force-pushed
the
feature/task-run-model
branch
from
c236d0e to
1f0c4c5
Compare
handle NotImplementedError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add task run and file storage models.