Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markdown decoder not recognizing all ul tokens #445

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Fix markdown decoder not recognizing all ul tokens #445

merged 2 commits into from
Jan 1, 2025

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Jan 1, 2025

Fixes #442

@Amir-P Amir-P requested a review from amantoux January 1, 2025 07:06
@Amir-P Amir-P mentioned this pull request Jan 1, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (c391628) to head (35283c4).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   88.26%   88.75%   +0.48%     
==========================================
  Files          62       62              
  Lines       10619    11169     +550     
==========================================
+ Hits         9373     9913     +540     
- Misses       1246     1256      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amantoux
amantoux reviewed Jan 1, 2025
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Amir-P
One question: do we want to opt-in the different characters as they seem standard?

amantoux
amantoux approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amantoux amantoux merged commit 4c3d05a into master Jan 1, 2025
4 checks passed
@Amir-P Amir-P deleted the fix/markdown_decoder_not_recognizing_all_ul_tokens branch January 1, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amantoux amantoux amantoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown encoder/decoder doesn't recognize "-" as start of unordered list item
2 participants
@Amir-P @amantoux