-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: enanble custom TextSelectionControls #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing it. LGTM. Can you also take care of adding a test for this please?
I tried adding a test, please check the following |
@kfdykme can you please format the changes using |
- format code
Thanks for the reminder, I have formatted it now. |
@kfdykme you still have a analysis issue |
sorry , fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 87.90% 87.91% +0.01%
==========================================
Files 62 62
Lines 10329 10330 +1
==========================================
+ Hits 9080 9082 +2
+ Misses 1249 1248 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Hello, there is a bug in Flutter's
OverlayEntry
handling related toTextSelectionTheme.of(context)
. Specifically, the issue causes the color ofMaterialTextSelectionControls
to be lost whenbuildHandle
is called. This can be seen in the Flutter source code at https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/text_selection.dart#L77.A simple way to fix this issue would be to allow developers to use a custom
TextSelectionControls
implementation.