Release v1.16.0 #370
Merged
Release v1.16.0 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
=======================================
Coverage 87.96% 87.96%
=======================================
Files 64 64
Lines 10433 10433
=======================================
Hits 9177 9177
Misses 1256 1256 ☔ View full report in Codecov by Sentry. |
Amir-P
reviewed
Jun 22, 2024
packages/fleather/CHANGELOG.md
Outdated
Comment on lines
4
to
6
| * Enable auto-correct on mobile devices | ||
| * Enable suggestions on Android devices | ||
| * Adjust theme to dark mode |
There was a problem hiding this comment.
Suggested change
| * Enable auto-correct on mobile devices | |
| * Enable suggestions on Android devices | |
| * Adjust theme to dark mode | |
| * [Behavior change] Add `autocorrect` which defaults to `true` | |
| * [Behavior change] Add `enableSuggestions` which defaults to `true` | |
| * [UI change] Adjust default theme |
There was a problem hiding this comment.
I don't think we should add to many tags to the release note for readability
It is not a breaking change it is an enhancement
Nevertheless, we must precise that auto correct only works for mobile and suggestions only on Android
There was a problem hiding this comment.
I still prefer to let the user know it's going to break the UI and behavior but your version is fine too. Just please change the theme changelog since it affects the light theme too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.