Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix theming for dark themes #365

Merged
merged 4 commits into from
Jun 15, 2024
Merged

Fix theming for dark themes #365

merged 4 commits into from
Jun 15, 2024

Conversation

maelchiotti
Copy link
Contributor

@maelchiotti maelchiotti commented Jun 9, 2024 •
edited
Loading

Fixes #363.

Changes:

  • Horizontal rule: all theme
  • Inline code: radius (to be the same as code blocks), background color
  • Quote: background color
  • Code block: text color and opacity (to be the same as inline code), background color

@maelchiotti maelchiotti mentioned this pull request Jun 9, 2024
Closed
Amir-P
Amir-P requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@Amir-P Amir-P left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! I really liked the new theme. Just had a small concern with horizontal rule. Please take a look.

packages/fleather/lib/src/widgets/editor.dart Outdated Show resolved Hide resolved
@maelchiotti maelchiotti requested a review from Amir-P June 11, 2024 17:07
@maelchiotti maelchiotti requested a review from Amir-P June 12, 2024 16:20
Amir-P
Amir-P approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@Amir-P Amir-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again. @maelchiotti
Do you want to take a look too? @amantoux

@Amir-P Amir-P requested a review from amantoux June 12, 2024 16:46
amantoux
amantoux approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@codecov Codecov
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (178d2bb) to head (519835f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   87.90%   87.92%   +0.02%     
==========================================
  Files          64       64              
  Lines       10382    10403      +21     
==========================================
+ Hits         9126     9147      +21     
  Misses       1256     1256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amantoux amantoux merged commit 810ce7a into fleather-editor:master Jun 15, 2024
3 checks passed
@maelchiotti maelchiotti deleted the fix/theming branch August 2, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amantoux amantoux amantoux approved these changes

@Amir-P Amir-P Amir-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the colors of inline code and code blocks
3 participants
@maelchiotti @Amir-P @amantoux