Enable auto correct

[simonbengtsson]

I thought it would be a major undertaking, but after some research it turns out toggling the autocorrect flag was enough. Is there a reason this was turned off or can it be enabled? Auto correct was one of the main reasons that made me still reach for Apple Notes at times.

Note that I'm using Google Keyboard in the attached demo and auto correct also worked when I tried with SwiftKey. I could not get it to work with the default iOS keyboard (not in English nor Swedish). Any thoughts on that? My guess it is some kind of locale setting either on my device or with the Fleather editor somehow.

RPReplay_Final1716982462.mp4

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (34b56e7) to head (7c36d13).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   87.89%   87.90%           
=======================================
  Files          64       64           
  Lines       10379    10382    +3     
=======================================
+ Hits         9123     9126    +3     
  Misses       1256     1256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Amir-P]

Thank you for contributing! I personally disable the auto correction the moment I setup my devices so never noticed we're missing auto correction. But it would make sense to have a flag to control it from 'FleatherEditor' and 'FleatherField'.

[simonbengtsson]

Oh really? You must have amazing finger control. Updated PR now with a new autocorrect flag for both FleatherEditor and FleatherField. Something like this you had in mind? I used the same doc comment used for the TextField widget in flutter.

[Amir-P]

Thanks! I left a comment for you. PTAL.

[Amir-P]

I accidentally deleted my previous review. Left you some comments please take a look.

[Amir-P]

Note that I'm using Google Keyboard in the attached demo and auto correct also worked when I tried with SwiftKey. I could not get it to work with the default iOS keyboard (not in English nor Swedish). Any thoughts on that? My guess it is some kind of locale setting either on my device or with the Fleather editor somehow.

BTW, the auto correction seems to be working fine on iOS too.

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-29.at.22.34.00.mov

[Amir-P]

Thanks, LGTM! @amantoux Do you wanna take a look too?

[amantoux]

LGTM