Fix analysis issues with Flutter v3.22 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! Completely forgot about that. Now we have failing tests. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
==========================================
- Coverage 87.97% 87.89% -0.08%
==========================================
Files 64 64
Lines 10380 10379 -1
==========================================
- Hits 9132 9123 -9
- Misses 1248 1256 +8 ☔ View full report in Codecov by Sentry. |
amantoux
reviewed
May 29, 2024
| // The addition of 1 point to testOffset.dy is added because somehow in | ||
| // Flutter 3.22 the text painer for the offset is yielding wrong | ||
| // text position (1 line above the correct line). | ||
| final finalOffset = Offset(caretOffset.dx, testOffset.dy + 1); |
There was a problem hiding this comment.
Really strange, no explanation for this?
There was a problem hiding this comment.
Couldn't find any. I even took a quick look at the commits in framework and engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.