List numbers should follow the theme

[amantoux]

Closes #264

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (cc3921c) to head (350547d).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          64       64           
  Lines       10284    10284           
=======================================
  Hits         9026     9026           
  Misses       1258     1258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amantoux]

@Amir-P no tests here neither, sounds like overkill. Ok with you?

[Amir-P]

Thanks for the PR. The bottom alignment seems to fail when the text inside list breaks into multiple lines. In the screenshot, the top editor uses 1.8, the one in the middle 1.3 and the bottom one uses 1.0 as style height.

I think we need to align the leading widget to the baseline instead of top or bottom. What do you think? Here is the same styles for unordered list:

[amantoux]

Yes, aligning to baseline is way to go

Need to find the right way to do so

@Amir-P shouldn't we address this in a separate PR?

[Amir-P]

@Amir-P shouldn't we address this in a separate PR?

You mean merging this one as is? I don't find it in a mergeable state since it's introducing a new issue which is more severe than the one it's fixing. @amantoux

[amantoux]

@Amir-P shouldn't we address this in a separate PR?

You mean merging this one as is? I don't find it in a mergeable state since it's introducing a new issue which is more severe than the one it's fixing. @amantoux

No obviously
Restoring alignment

[Amir-P]

LGTM. We will address the alignment issue in another PR.