Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent toolbar from leaving editor #336

Merged
merged 2 commits into from
May 6, 2024
Merged

Prevent toolbar from leaving editor #336

merged 2 commits into from
May 6, 2024

Conversation

amantoux
Copy link
Member

@amantoux amantoux commented Apr 30, 2024 •
edited
Loading

Fixes #335

  • add tests

@amantoux amantoux requested a review from Amir-P April 30, 2024 15:38
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.81%. Comparing base (428bf54) to head (d2fa537).

Files Patch % Lines
packages/fleather/lib/src/widgets/editor.dart 93.75% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   87.76%   87.81%   +0.04%     
==========================================
  Files          64       64              
  Lines       10284    10293       +9     
==========================================
+ Hits         9026     9039      +13     
+ Misses       1258     1254       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amantoux
Copy link
Member Author

amantoux commented Apr 30, 2024 •
edited
Loading

New behavior

Screen_recording_20240430_200037.webm

@amantoux amantoux force-pushed the fix/toolbar_out_of_editor branch from 8aaac2d to 30daa18 Compare May 6, 2024 14:19
Amir-P
Amir-P approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@Amir-P Amir-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Amir-P Amir-P merged commit 491642c into master May 6, 2024
4 checks passed
@Amir-P Amir-P deleted the fix/toolbar_out_of_editor branch May 6, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amir-P Amir-P Amir-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toolbar can be scrolled out of editor
2 participants
@amantoux @Amir-P