Enhancing FleatherToolbar with Customizable Heading Labels for User-Guided Text Formatting #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll remove this and re-add with a clean pull request that also includes the required tests and such |
|
I guess this can be closed @Amir-P? The issue remains but this solution does not fit how the translations work anymore. |
|
Yes, indeed. I'll close this and create an issue for fixing in future. Thanks for pointing this out. @maelchiotti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, Thanks for the amazing work on this package.
I propose an enhancement to the FleatherToolbar class to support customizable heading labels. This feature introduces optional parameters: normalLabel, heading1Label, heading2Label, heading3Label, heading4Label, heading5Label, and heading6Label. These parameters allow for the customization of toolbar heading labels, facilitating user guidance in text formatting, such as preset alert text formats. The implementation updates the _headingToText map to utilize these parameters, offering a flexible approach to managing text input formats. This addition aims to improve user experience by enabling more descriptive and context-specific toolbar labels.
I think this would be a good addition with minimal impact but improving the overall flexibility of the package
Edit: I'm not so used to pull requests so my other fix was also included with this one.