Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide collapsed selection handle when editor is read-only #299

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Mar 25, 2024

Fixes #297.

@Amir-P Amir-P requested a review from amantoux March 25, 2024 09:16
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (a79d6d0) to head (6431e42).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   87.65%   87.67%   +0.01%     
==========================================
  Files          64       64              
  Lines       10408    10422      +14     
==========================================
+ Hits         9123     9137      +14     
  Misses       1285     1285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amantoux amantoux merged commit 5e8ab2b into master Mar 25, 2024
4 checks passed
@Amir-P Amir-P deleted the fix/read_only_selection_handle_visibility branch March 25, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection handle is visible when editor is read-only and selection is collapsed
2 participants