Scroll to selection after keyboard opened #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
==========================================
- Coverage 87.71% 87.45% -0.27%
==========================================
Files 64 64
Lines 10416 11363 +947
==========================================
+ Hits 9136 9937 +801
- Misses 1280 1426 +146 ☔ View full report in Codecov by Sentry. |
amantoux
requested changes
Mar 25, 2024
| @@ -1474,6 +1474,7 @@ class RawEditorState extends EditorState | |||
| if (_hasFocus) { | |||
| // Listen for changing viewInsets, which indicates keyboard showing up. | |||
| WidgetsBinding.instance.addObserver(this); | |||
| _lastBottomViewInset = View.of(context).viewInsets.bottom; | |||
There was a problem hiding this comment.
Isn't this redundant with didChangeMetrics?
There was a problem hiding this comment.
We are not receiving view inset changes while editor is unfocused. In order to have the latest bottom view inset we are fetching it when editor gained focus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #280.