Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RenderEditableTextLine's getPositionAbove #207

Merged
merged 5 commits into from
Jan 6, 2024
Merged

Fix RenderEditableTextLine's getPositionAbove #207

merged 5 commits into from
Jan 6, 2024

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Jan 5, 2024

Fixes #192

@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e043d4f) 86.79% compared to head (0d0e9d5) 87.17%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   86.79%   87.17%   +0.37%     
==========================================
  Files          63       63              
  Lines       10283    10289       +6     
==========================================
+ Hits         8925     8969      +44     
+ Misses       1358     1320      -38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amir-P Amir-P requested a review from amantoux January 5, 2024 14:16
amantoux
amantoux requested changes Jan 5, 2024
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @Amir-P
Can you please take a look at the comment I left?

packages/fleather/lib/src/rendering/editable_text_line.dart Outdated Show resolved Hide resolved
@Amir-P Amir-P requested a review from amantoux January 6, 2024 17:08
amantoux
amantoux requested changes Jan 6, 2024
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Amir-P
I still have a question/comment. Can you let me know your thoughts?

packages/fleather/lib/src/rendering/editable_text_line.dart Outdated Show resolved Hide resolved
@Amir-P Amir-P requested a review from amantoux January 6, 2024 18:28
amantoux
amantoux approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@amantoux amantoux merged commit f38278c into master Jan 6, 2024
4 checks passed
@amantoux amantoux deleted the fix/text_line_get_position_above branch January 6, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amantoux amantoux amantoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected behavior of vertical cursor movements from a line with span embeds
2 participants
@Amir-P @amantoux