Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.12.0 #193

Merged
merged 5 commits into from
Dec 10, 2023
Merged

Release v1.12.0 #193

merged 5 commits into from
Dec 10, 2023

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Dec 10, 2023

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cd43c4) 86.43% compared to head (e502da3) 86.43%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files          62       62           
  Lines        9679     9679           
=======================================
  Hits         8366     8366           
  Misses       1313     1313

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amir-P
Copy link
Member Author

Amir-P commented Dec 10, 2023

I had to remove publish_to because of pub.dev hence had to remove local Parchment too. @amantoux

@Amir-P Amir-P requested a review from amantoux December 10, 2023 13:24
@Amir-P Amir-P marked this pull request as ready for review December 10, 2023 13:24
amantoux
amantoux requested changes Dec 10, 2023
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small spelling issue

packages/parchment/CHANGELOG.md Outdated Show resolved Hide resolved
packages/fleather/CHANGELOG.md Outdated Show resolved Hide resolved
@Amir-P Amir-P requested a review from amantoux December 10, 2023 13:31
amantoux
amantoux approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amir-P Amir-P merged commit cc0ea76 into master Dec 10, 2023
4 checks passed
@Amir-P Amir-P deleted the release/v1.12.0 branch December 10, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amantoux amantoux amantoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amir-P @amantoux