Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text direction auto format detection and undo #191

Merged
merged 4 commits into from
Dec 10, 2023

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Dec 10, 2023

It fixes two issues:

  1. When users enters a character in an empty line with line style auto text direction is not working correctly
  2. When auto format applies the same style the undo is an empty delta and applying it causes exception

@Amir-P Amir-P requested a review from amantoux December 10, 2023 09:44
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c3e95f) 86.42% compared to head (58d7083) 86.56%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   86.42%   86.56%   +0.14%     
==========================================
  Files          62       62              
  Lines        9672     9812     +140     
==========================================
+ Hits         8359     8494     +135     
- Misses       1313     1318       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amir-P
Copy link
Member Author

Amir-P commented Dec 10, 2023

Also there is a small behavioral difference with Google Docs. Google Docs doesn't have an undo for auto text direction and just remove the entered character. Should we change it too? @amantoux

Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

packages/fleather/lib/src/widgets/controller.dart Outdated Show resolved Hide resolved
@Amir-P Amir-P requested a review from amantoux December 10, 2023 10:15
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@Amir-P Amir-P merged commit 6cd43c4 into master Dec 10, 2023
4 checks passed
@amantoux amantoux deleted the fix/auto_text_direction branch December 17, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants