-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text direction auto format detection and undo #191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 86.42% 86.56% +0.14%
==========================================
Files 62 62
Lines 9672 9812 +140
==========================================
+ Hits 8359 8494 +135
- Misses 1313 1318 +5 ☔ View full report in Codecov by Sentry. |
Also there is a small behavioral difference with Google Docs. Google Docs doesn't have an undo for auto text direction and just remove the entered character. Should we change it too? @amantoux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
It fixes two issues: