Android - add selection handle on collapsed selection

fleather-editor · Jan 1, 2024 · 714b478 · 714b478
1 parent 5c77e83
commit 714b478
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 17 deletions.
diff --git a/packages/fleather/lib/src/widgets/editor.dart b/packages/fleather/lib/src/widgets/editor.dart
@@ -1265,11 +1265,6 @@ class RawEditorState extends EditorState
     performSpellCheck(widget.controller.plainTextEditingValue.text);
   }
 
-  bool _shouldShowSelectionHandles() {
-    return widget.showSelectionHandles &&
-        !widget.controller.selection.isCollapsed;
-  }
-
   @override
   void didUpdateWidget(RawEditor oldWidget) {
     super.didUpdateWidget(oldWidget);
@@ -1306,11 +1301,7 @@ class RawEditorState extends EditorState
       _selectionOverlay?.update(textEditingValue);
     }
 
-    if (_shouldShowSelectionHandles()) {
-      _selectionOverlay?.showHandles();
-    } else {
-      _selectionOverlay?.hideHandles();
-    }
+    _selectionOverlay?.handlesVisible = widget.showSelectionHandles;
 
     if (!shouldCreateInputConnection) {
       closeConnectionIfNeeded();
@@ -1385,13 +1376,8 @@ class RawEditorState extends EditorState
       } else {
         _selectionOverlay!.update(textEditingValue);
       }
-
-      if (_shouldShowSelectionHandles()) {
-        _selectionOverlay!.handlesVisible = widget.showSelectionHandles;
-        _selectionOverlay?.showHandles();
-      } else {
-        _selectionOverlay?.hideHandles();
-      }
+      _selectionOverlay!.handlesVisible = widget.showSelectionHandles;
+      _selectionOverlay!.showHandles();
     }
 
     // This will show the keyboard for all selection changes on the

diff --git a/packages/fleather/test/widgets/editor_test.dart b/packages/fleather/test/widgets/editor_test.dart
@@ -441,6 +441,23 @@ void main() {
             const TypeMatcher<MaterialTextSelectionControls>());
       }, [TargetPlatform.android]);
 
+      testWidgetsWithPlatform(
+          'show single selection handle when setting cursor position (Android)',
+          (tester) async {
+        final document = ParchmentDocument.fromJson([
+          {'insert': 'Some piece of text\n'}
+        ]);
+        final editor =
+            EditorSandBox(tester: tester, document: document, autofocus: true);
+        await editor.pump();
+        await tester.tapAt(tester.getTopLeft(find.byType(FleatherEditor)) +
+            const Offset(30, 1));
+        tester.binding.scheduleWarmUpFrame();
+        await tester.pump();
+        final handleOverlays = find.byType(SelectionHandleOverlay);
+        expect(handleOverlays, findsOneWidget);
+      }, [TargetPlatform.android]);
+
       testWidgets('dragging collapsed selection shows magnifier',
           (tester) async {
         final document = ParchmentDocument.fromJson([