Remove selection gestures when enableInteractiveSelection is false (#…

…351)

* Remove selection gesture detector when enableInteractiveSelection is `false`

packages/fleather/lib/src/widgets/editor.dart

@@ -491,10 +491,10 @@ class _FleatherEditorState extends State<FleatherEditor>
       ),
     );
 
-    return _selectionGestureDetectorBuilder.buildGestureDetector(
-      behavior: HitTestBehavior.translucent,
-      child: child,
-    );
+    return widget.enableInteractiveSelection
+        ? _selectionGestureDetectorBuilder.buildGestureDetector(
+            behavior: HitTestBehavior.translucent, child: child)
+        : child;
   }
 }
 

packages/fleather/test/testing.dart

@@ -15,6 +15,7 @@ class EditorSandBox {
     ParchmentDocument? document,
     FleatherThemeData? fleatherTheme,
     bool autofocus = false,
+    bool enableSelectionInteraction = true,
     FakeSpellCheckService? spellCheckService,
     ClipboardManager clipboardManager = const PlainTextClipboardManager(),
     FleatherEmbedBuilder embedBuilder = defaultFleatherEmbedBuilder,
@@ -27,6 +28,7 @@ class EditorSandBox {
       controller: controller,
       focusNode: focusNode,
       autofocus: autofocus,
+      enableSelectionInteraction: enableSelectionInteraction,
       spellCheckService: spellCheckService,
       embedBuilder: embedBuilder,
       clipboardManager: clipboardManager,
@@ -139,6 +141,7 @@ class _FleatherSandbox extends StatefulWidget {
     required this.controller,
     required this.focusNode,
     this.autofocus = false,
+    this.enableSelectionInteraction = true,
     this.spellCheckService,
     this.embedBuilder = defaultFleatherEmbedBuilder,
     this.clipboardManager = const PlainTextClipboardManager(),
@@ -147,6 +150,7 @@ class _FleatherSandbox extends StatefulWidget {
   final FleatherController controller;
   final FocusNode focusNode;
   final bool autofocus;
+  final bool enableSelectionInteraction;
   final FakeSpellCheckService? spellCheckService;
   final FleatherEmbedBuilder embedBuilder;
   final ClipboardManager clipboardManager;
@@ -167,6 +171,7 @@ class _FleatherSandboxState extends State<_FleatherSandbox> {
         controller: widget.controller,
         focusNode: widget.focusNode,
         readOnly: !_enabled,
+        enableInteractiveSelection: widget.enableSelectionInteraction,
         autofocus: widget.autofocus,
         spellCheckConfiguration: widget.spellCheckService != null
             ? SpellCheckConfiguration(
@@ -178,9 +183,7 @@ class _FleatherSandboxState extends State<_FleatherSandbox> {
   }
 
   void disable() {
-    setState(() {
-      _enabled = false;
-    });
+    setState(() => _enabled = false);
   }
 }
 

packages/fleather/test/widgets/editor_test.dart

@@ -392,6 +392,14 @@ void main() {
     });
 
     group('Text selection', () {
+      testWidgets('disabled selection interaction disables associated gestures',
+          (tester) async {
+        final editor =
+            EditorSandBox(tester: tester, enableSelectionInteraction: false);
+        await editor.pump();
+        expect(find.byType(TextSelectionGestureDetector), findsNothing);
+      });
+
       testWidgets('hides toolbar and selection handles when text changed',
           (tester) async {
         const delta = TextEditingDeltaInsertion(