Modify layout styles for Material Design #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes divider - Uses an "OK/Cancel" paradigm as suggested by guidelines for picker dialogs - Changes padding and other layout metrics to match guidelines - Changes "OK/Cancel" font style and color to match dialog guidelines
- Vibrator system service was previously called using a hard-coded string, which could change in future Android versions
- Removes divider - Uses an "OK/Cancel" paradigm as suggested by guidelines for picker dialogs - Changes colors to match native TimePickerDialog in Lollipop
…ontainer in landscape This is unnecessary in portrait mode, but may suffice for now.
shaun-blake
added a commit
to shaun-blake-experiments/hour-minute-picker
that referenced
this pull request
Mar 19, 2016
shaun-blake
added a commit
to shaun-blake-experiments/hour-minute-picker
that referenced
this pull request
Mar 19, 2016
shaun-blake
added a commit
to shaun-blake-experiments/hour-minute-picker
that referenced
this pull request
Mar 19, 2016
shaun-blake
added a commit
to shaun-blake-experiments/hour-minute-picker
that referenced
this pull request
Mar 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made layout changes to match the current Material guidelines for Pickers.
Android Lollipop has native
DatePickers andTimePickers that look like the following:These new pickers are not ported to pre-Android 5.0, even with AppCompat, so I followed the guidelines as close as possible to create a similar look for this library:
while still retaining the original color theme used in this repo (if anyone needs to use custom colors, please see #65 (comment))
Changes made are mostly to layout or style xml files. Commits are self-contained and easy to review.
Tested on Nexus 7, 5 & 4.