Small cleanups for the File Transfer portal code #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used outside this compilation unit.
No functional changes.
swick
reviewed
Jan 16, 2025
Comment on lines
-147
to
+155
| FileTransfer *transfer; | ||
| g_autoptr(FileTransfer) transfer = NULL; | ||
|
|
||
| G_LOCK (transfers); | ||
| transfer = (FileTransfer *)g_hash_table_lookup (transfers, key); | ||
| if (transfer) | ||
| g_object_ref (transfer); | ||
| G_UNLOCK (transfers); | ||
|
|
||
| return transfer; | ||
| return g_steal_pointer (&transfer); |
There was a problem hiding this comment.
transfer actually isn't owning the FileTransfer for some time which is a bit awkward. Maybe it gets more readable by ref-ing at the return?
FileTransfer *transfer;
G_LOCK (transfers);
transfer = (FileTransfer *)g_hash_table_lookup (transfers, key);
G_UNLOCK (transfers);
if (!transfer)
return NULL;
return g_object_ref (transfer);
|
LGTM, one nit pick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.