XdpAppInfo: set missing is_valid_sub_app_id in class_init #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgesStavracas
approved these changes
Jan 5, 2025
|
Version 1.18 was not affected. Latest postmarketOS / Alpine Linux releases already ship xdg-desktop-portal 1.19.0. Don't know why they ship a prerelease version in their stable channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic launcher portal is broken in postmarketOS v24.12. Seems the
xdp_app_info_flatpak_is_valid_sub_app_id()andxdp_app_info_host_is_valid_sub_app_id()were forgotten to be added to theclass_init()functions.