overlay coreos-base/afterburn: update to 5.5.0 #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
had a problem deploying
to
development
GitHub Actions
Error
dongsupark
force-pushed
the
dongsu/afterburn-5.5.0
branch
from
b304ffc to
034b484
Compare
dongsupark
temporarily deployed
to
development
GitHub Actions
Inactive
pothos
reviewed
Dec 5, 2023
...c/third_party/coreos-overlay/coreos-base/afterburn/files/0003-vmware-arm64-unsupported.patch
Show resolved
Hide resolved
pothos
reviewed
Dec 5, 2023
sdk_container/src/third_party/coreos-overlay/coreos-base/afterburn/files/0004-lto-thin.patch
Show resolved
Hide resolved
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/7126840287 |
Update afterburn to the latest release 5.5.0. https://github.com/coreos/afterburn/releases/tag/v5.5.0. Regenerate its dependency crate list.
Adjust Flatcar patches 000[12]* for afterburn 5.5.0. For 0001* to be compiled, it is necessary to add again the hostname crate, which is not included in 5.5 any more by default.
0003-encode-information-for-systemd-networkd-wait-online.patch can be dropped, as it was already merged to upstream. coreos/afterburn@d2cc340 Since upstream does not enable `lto = true` any more in coreos/afterburn@464c7f9, it is not necessary to keep the LTO patch. Just drop it.
Fix build issue that started to appear in afterburn 5.5.0. Every public function for the amd64 part must have a corresponding empty function in the unsupported part, so that cross-compile for arm64 can work.
dongsupark
force-pushed
the
dongsu/afterburn-5.5.0
branch
from
034b484 to
6f715d8
Compare
dongsupark
had a problem deploying
to
development
GitHub Actions
Error
pothos
reviewed
Dec 6, 2023
...ty/coreos-overlay/coreos-base/afterburn/files/0004-cargo-codegen-units-release-profile.patch
Outdated
Show resolved
Hide resolved
In the release profile of Cargo.toml, add `codegen-units = 1`, `strip = true`, and remove `debug = true`, to reduce binary size of afterburn included in production images.
dongsupark
force-pushed
the
dongsu/afterburn-5.5.0
branch
from
6f715d8 to
4f56174
Compare
dongsupark
had a problem deploying
to
development
GitHub Actions
Failure
|
CI passed for all cloud providers. |
|
cherry-picked to flatcar-3760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
coreos-base/afterburnto the latest release 5.5.0.Adjust Flatcar patches for 5.5.0, it is necessary to add again the
hostnamecrate, which is not included in 5.5 any more by default.Remove unnecessary patches for 5.5.0.
0003-encode-information-for-systemd-networkd-wait-online.patch: it is already merged in upstream, coreos/afterburn@d2cc340.0004-lto-thin.patch: it is not needed any more, since upstream does not enablelto = trueany more in coreos/afterburn@464c7f9.Fix build issue that started to appear in afterburn 5.5.0. Every public function for the amd64 part must have a corresponding empty function in the unsupported part, so that cross-compile for arm64 can work.
(See also coreos/afterburn#1022)
Needs to be cherry-picked to Beta,
flatcar-3760.Fixes flatcar/Flatcar#1049.
Testing done
CI (for all cloud providers): http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/3058/cldsv/
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.