Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regression): loading next discussion list pages fails #3547

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jul 19, 2022

Fixes #3546

Changes proposed in this pull request:
Regression introduced in #3536, defaults to 1 for the page number.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 requested a review from davwheat July 19, 2022 14:49
@SychO9 SychO9 merged commit 31a00ee into main Jul 19, 2022
@SychO9 SychO9 deleted the sm/3546-fix-discussionlist-api-page-loading branch July 19, 2022 18:22
@luceos luceos mentioned this pull request Jul 30, 2022
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking load more shows the same discussions again
2 participants