Fix bugs with Implied DO #1445
Merged
Fix bugs with Implied DO #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawosm-arm
approved these changes
May 15, 2024
bryanpkc
force-pushed
the
fix-implied-do-bugs
branch
from
374195e
to
919b5f2
Compare
Add support for implied DO loop with substring in initialization.
The variables in a common block from a module will be copied into current scope when a USE exists. However, the dinit feature of those copied variables was removed when lowering symbols in flang1. This patch suppresses the transformation of those copied variables to the corresponding constant initialized in the common block, since we cannot get their initialization info anyway.
shivaramaarao
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1444. With these patches, I have verified that libmbd builds successfully on both AArch64 and X86, although I haven't tested the correctness of the resulting library.