Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not encode HTML by default when parsing markdown [flame_markdown] #3425

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

luanpotter
Copy link
Member

@luanpotter luanpotter commented Dec 26, 2024

Description

Do not encode HTML by default when parsing markdown [flame_markdown].

The Flame text rendering pipeline is not configured to accept HTML encoded sequences, therefore the default behaviour of Flame Markdown doesn't lead to a good result:

image

With this change:

image

Of the user can still override it as before.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter requested a review from spydon December 26, 2024 22:04
@luanpotter luanpotter merged commit 3067da9 into main Dec 27, 2024
8 checks passed
@luanpotter luanpotter deleted the luan.markdown branch December 27, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants