feat!: Make resource creation be on demand to enable testing #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
commented
Dec 15, 2024
| @@ -10,6 +10,8 @@ import 'package:flutter_gpu/gpu.dart' as gpu; | |||
| /// | |||
| /// {@endtemplate} | |||
| class ShaderResource extends Resource<gpu.Shader> { | |||
There was a problem hiding this comment.
with the new Resource design there is no longer a need to separate ShaderResource and Shader for testing purposes
one would be able to create a "Shader" in tests no problem as long as they don't call the .resource getter
if this new pattern is accepted, I can followup with updating this to be simpler as it was before
luanpotter
changed the title
luanpotter
force-pushed
the
luan.flame-3d-delayed-resources
branch
from
2447f54 to
4c5f726
Compare
spydon
approved these changes
Dec 30, 2024
luanpotter
changed the title
Benchmark ResultsPackage flame:
Benchmarks provided with 💙 by Dart Benchmark Action. |
spydon
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make resource creation be on demand to enable testing.
Basically changes how the
Resourceclass work:Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?