feat!: Refactor the CameraComponent3D
#3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfenrain
commented
Dec 14, 2024
Comment on lines
+38
to
+45
| // Compute the desired position based on the rotation and distance. | ||
| final desiredPosition = following + _getRotatedOffset(); | ||
|
|
||
| // Smoothly interpolate the camera's position toward the desired position. | ||
| position = position + (desiredPosition - position) * (followDamping * dt); | ||
|
|
||
| // Always look at the following point. | ||
| target.setFrom(following); |
There was a problem hiding this comment.
This math is not yet perfect, it seems to sometimes overflow and reset the rotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the users to create their own camera component while also providing a few basic camera components
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues